Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] "open pull request" capability #1281

Open
neubig opened this issue Apr 22, 2024 · 2 comments · May be fixed by #1660
Open

[Feature] "open pull request" capability #1281

neubig opened this issue Apr 22, 2024 · 2 comments · May be fixed by #1660
Labels
enhancement New feature or request severity:medium Problems that affect many users
Milestone
2024-05

Comments

@neubig
Copy link
Contributor

neubig commented Apr 22, 2024

What problem or use case are you trying to solve?

We would like to solve github issues using OpenDevin: #1067

OpenDevin can get most of the way there, but when it tries to "git push" it will not work, because it does not have appropriate permissions to push to github and send a PR.

Describe the UX of the solution you'd like

To fix this, I think we should probably add an OpenPullRequest action to our agents.

  1. In the case where the user has not configured github credentials, this will trigger a message to the user that in order for the agent to proceed, they should enter their github credentials or cancel.
  2. In the case where the user has configured github credentials, this will send a PR to a branch, and open up the github PR page for the user to review the PR before they actually click the "submit pull request" button themselves.

Describe alternatives you've considered

Another althernative is to let OpenDevin actually do the PR itself, but this is too risky.
@neubig neubig added the enhancement New feature or request label Apr 22, 2024
@temotskipa
Copy link
Contributor

but this is too risky

I mean, you could just not approve the PR if the generated code is somehow malicious. Which is extremely unlikely.

@neubig
Copy link
Contributor Author

neubig commented Apr 22, 2024 •
edited

That's true, but OpenDevin could also accidentally push something directly to the main branch without sending a PR (for repos without branch protection, of which there are many). I'd kinda like to avoid giving Devin credentials to do something on github directly and have access be somewhat more controlled.

@rbren rbren added the severity:low Minor issues, code cleanup, etc label May 2, 2024
@neubig neubig linked a pull request May 10, 2024 that will close this issue
Draft
@neubig neubig added this to the 2024-05 milestone May 14, 2024
@neubig neubig added severity:medium Problems that affect many users and removed severity:low Minor issues, code cleanup, etc labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request severity:medium Problems that affect many users
Projects
None yet
Milestone
2024-05
Development

Successfully merging a pull request may close this issue.

Pull Request Agent (plus, Microagent workflows) OpenDevin/OpenDevin
3 participants
@neubig @rbren @temotskipa