Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mitigation for cases, where the Context object becomes invalid #29141

Merged
merged 7 commits into from
May 27, 2024
Merged

Add mitigation for cases, where the Context object becomes invalid #29141

merged 7 commits into from
May 27, 2024

Conversation

hegyibalint
Copy link
Member

@hegyibalint hegyibalint commented May 14, 2024 •
edited

This PR adds some mitigations found by some users, when they tried to report problems with:

  • JDK 1.8
  • Using any kind of annotation processing

@hegyibalint hegyibalint added in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures in:problems problems api labels May 14, 2024
@hegyibalint hegyibalint requested a review from a team May 14, 2024 13:40
@hegyibalint hegyibalint self-assigned this May 14, 2024
@hegyibalint hegyibalint added this to the 8.9 RC1 milestone May 14, 2024
@hegyibalint hegyibalint linked an issue May 14, 2024 that may be closed by this pull request
Compiler problem reporting causes IllegalArgumentException with Java 8 is used with an annotation processor present #29113
Closed
@hegyibalint hegyibalint changed the title Add mitigation for cases, where the Context object becomes invalid Add mitigation for cases, where the Context object becomes invalid May 14, 2024
@hegyibalint hegyibalint marked this pull request as ready for review May 24, 2024 13:43
@hegyibalint hegyibalint requested a review from a team as a code owner May 24, 2024 13:43
@hegyibalint hegyibalint requested a review from ghale May 24, 2024 13:43
@hegyibalint hegyibalint added this pull request to the merge queue May 27, 2024
Merged via the queue into master with commit 784abfc May 27, 2024
25 checks passed
@hegyibalint hegyibalint deleted the bhegyi/problems/java-compile/fix-formatting-exception branch May 27, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donat donat donat approved these changes

@ghale ghale Awaiting requested review from ghale ghale is a code owner automatically assigned from gradle/bt-jvm

Assignees

@hegyibalint hegyibalint

Labels
in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures in:problems problems api
Projects
None yet
Milestone
8.9 RC1
3 participants
@hegyibalint @donat @tresat