-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Scheduler] Use allNodes when calculating nextStartNodeIndex #124933
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @alculquicondor |
Please add a release note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add an integration test using nodeAffinity, as reported in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks @AxeZhan !
LGTM label has been added. Git tree hash: 22c877b53f7130df6d99d567d7fa47cb9e506d3d
|
/retest |
/hold for @alculquicondor to take a final look for integration test. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AxeZhan, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @alculquicondor |
/priority critical-urgent |
/kind regression |
I can confirm that kube-scheduler v1.30.1 with this patch applied no longer crashes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
LGTM label has been added. Git tree hash: 7fe92a013c35cd69d90af4be353e948c20cd66fb
|
Please prepare cherry-picks to all supported versions |
…933-upstream-release-1.30 Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
…933-upstream-release-1.27 Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
…933-upstream-release-1.29 Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
…933-upstream-release-1.28 Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #124930
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: