-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Viewer integrated with eBPF #17073
base: master
Are you sure you want to change the base?
Conversation
89d88eb
to
d1028fc
Compare
Mentioning this here as discussed in the sync: Because the changes to the network viewer plugin involve new dependencies on code from the kernel-collector and ebpf CO-RE repos, changes in the packaging code will probably be required to ensure that the required eBPF programs are installed independent of whether the user as asked for the eBPF plugin or not. In the interest of simplifying that, it would be appreciated if we could ensure that either the programs used by the network-viewer all have a consistent pattern to their name that is different from what is used for the programs used for the existing eBPF plugin, or better yet that they be handled in a separate sub-directory. |
@Ferroin as an initial step, I suggest confirming that this ebpf integration works and is worth using. And only after get busy with packaging. Because I doubt it (at least this initial version (this PR) not tested by anybody) - prev ebpf network function in my opinion is 100% useless. |
b220c32
to
831c6e6
Compare
8bd0205
to
cb0968e
Compare
…pointer for LS_STATE
Summary
Fixes #16986 (partially)
More details when PR is ready
Test Plan
Compile branch and run netdata. The plugin
network-viwer
should run normally using/proc
files.Stop netdata;
Edit
netdata.conf
and append to collect using eBPF and managing the collection level:eBPF
software.It is also possible to collect with eBPF showing all task ids, but this could create a chart unreadable and a break of pattern with our
proc
collection. To visualize this, change step3
for:Additional Information
This PR was tested on:
For users: How does this change affect me?