From 8a6afe5581a58a066fb0084cb9960acdeddca7c5 Mon Sep 17 00:00:00 2001 From: Tina Mueller Date: Fri, 14 Aug 2015 13:51:53 +0200 Subject: [PATCH 1/2] add a TODO test for copy() --- t/icdt/engine_specific/sybase.t | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/t/icdt/engine_specific/sybase.t b/t/icdt/engine_specific/sybase.t index 5f6efc8fc..e114a8ee7 100644 --- a/t/icdt/engine_specific/sybase.t +++ b/t/icdt/engine_specific/sybase.t @@ -102,6 +102,31 @@ SQL cmp_ok( $row->$col->nanosecond, '==', $sample_dt->{nanosecond}, 'DateTime fractional portion roundtrip' ) if exists $sample_dt->{nanosecond}; + + { + # copy() uses get_columns() + # the values should survive a roundtrip also + + # my %col = $row->get_columns; + + # result: 2004-08-21T14:36:48.500Z + # error message from Sybase in an insert/update: + # Syntax error during implicit conversion of VARCHAR value + # '2004-08-21T14:36:48.500Z' to a DATETIME field. + + # doing this: + # $_[0]->dbh->syb_date_fmt('ISO'); + # will result in a string that's accepted for an insert, however + # then the default datetime parser + # DBIx::Class::Storage::DBI::Sybase::ASE::DateTime::Format + # will die on inflating. Additionally you will need + # DBIx::Class::Storage::DBI::Sybase::ASE + # ->datetime_parser_type("DateTime::Format::Sybase"); + local $TODO = "copy() doesn't work for datetime columns with the default datetime_setup"; + lives_ok(sub { + $row->copy + }, "copy()"); + } } # test a computed datetime column From d3f09d8eaf0943a1a049267168d183dfd5c04100 Mon Sep 17 00:00:00 2001 From: Tina Mueller Date: Fri, 14 Aug 2015 13:59:54 +0200 Subject: [PATCH 2/2] add tinita to AUTHORS --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 83632ef87..5db327936 100644 --- a/AUTHORS +++ b/AUTHORS @@ -200,6 +200,7 @@ teejay: Aaron Trevena theorbtwo: James Mastros Thomas Kratz timbunce: Tim Bunce +tinita: Tina Mueller Todd Lipcon Tom Hukins tommy: Tommy Butler