From b19d7d3b7a3d69ebcc065243cb74bdc4e26a15dc Mon Sep 17 00:00:00 2001 From: frank Date: Thu, 29 Oct 2026 11:59:12 -0500 Subject: [PATCH] Issue 2177: Add missing ARIA roles, names and states Addresses VPAT 4.1.2 Name, Role, Value. - Give clickable icons, spans, list items and divs role="button", tabindex and an accessible name, reusing the keyboard-activate directive from #2176 - Expose expand/collapse state with aria-expanded on sideboxes, accordion panes, filter groups, submission dialogs and the triptych - Hide collapsed content with visibility so its controls leave the tab order - Move remove handlers from inner icons onto their labelled buttons in the submission input types so keyboard activation works - Replace invalid aria-title with aria-label on modal close buttons - Add href to click-only anchors, tab semantics to the email workflow rule views, aria-sort to sortable columns, aria-current to submission steps - Add role="alert"/"status" to validation and advisor messages, alt text to images, and names to icon-only buttons and unlabeled fields Co-Authored-By: Claude Opus 5.5 --- .../webapp/app/resources/styles/sass/app.scss | 30 ++++++++++------ .../views/submission/_submissionDialog.scss | 6 ++++ .../views/admin/info/edit/input-checkbox.html | 4 +-- .../info/edit/input-conditional_textarea.html | 8 ++--- .../views/admin/info/edit/input-contact.html | 8 ++--- .../admin/info/edit/input-contact_select.html | 8 ++--- .../app/views/admin/info/edit/input-date.html | 8 ++--- .../admin/info/edit/input-degreedate.html | 8 ++--- .../views/admin/info/edit/input-email.html | 4 +-- .../views/admin/info/edit/input-license.html | 4 +-- .../views/admin/info/edit/input-orcid.html | 4 +-- .../views/admin/info/edit/input-password.html | 4 +-- .../views/admin/info/edit/input-proquest.html | 4 +-- .../views/admin/info/edit/input-radio.html | 2 +- .../views/admin/info/edit/input-select.html | 12 +++---- .../app/views/admin/info/edit/input-tel.html | 4 +-- .../app/views/admin/info/edit/input-text.html | 4 +-- .../views/admin/info/edit/input-textarea.html | 4 +-- .../app/views/admin/info/edit/input-url.html | 4 +-- src/main/webapp/app/views/admin/list.html | 6 ++-- .../settings/application/lookAndFeel.html | 34 ++++++++++++++++++- .../views/admin/settings/organization.html | 12 +++++-- .../organization/emailWorkflowRule.html | 6 ++-- .../organization/emailWorkflowRules.html | 10 +++--- .../workflowsteps/workflowStep.html | 8 ++--- .../controlledVocabularyManagement.html | 16 ++++----- src/main/webapp/app/views/admin/view.html | 6 ++-- .../app/views/directives/accordionPane.html | 8 ++--- .../app/views/directives/lockingTextArea.html | 10 +++--- .../app/views/directives/loginButton.html | 2 +- .../directives/reviewSubmissionFields.html | 12 +++---- .../webapp/app/views/directives/sidebox.html | 4 +-- .../directives/submissionDialog-actions.html | 8 +++-- .../directives/submissionDialog-advisor.html | 6 ++-- .../directives/submissionDialog-state.html | 6 ++-- .../app/views/directives/submissionInfo.html | 8 ++--- .../app/views/directives/tableControls.html | 12 ++++--- .../webapp/app/views/directives/triptych.html | 34 +++++++++---------- .../app/views/inputtype/input-contact.html | 4 +-- .../views/inputtype/input-contact_select.html | 4 +-- .../app/views/inputtype/input-date.html | 4 +-- .../app/views/inputtype/input-degreedate.html | 4 +-- .../app/views/inputtype/input-file.html | 16 ++++----- .../app/views/inputtype/input-select.html | 4 +-- .../settings/newLogoConfirmUploadModal.html | 2 +- .../modals/submissions/batchAssignTo.html | 2 +- .../modals/submissions/batchCommentEmail.html | 18 +++++----- .../submissions/batchDownloadExport.html | 2 +- .../modals/submissions/batchUpdateStatus.html | 2 +- .../submissions/confirmNewSubmission.html | 2 +- .../modals/submissions/customizeFilters.html | 10 +++--- .../submissions/customizeSubmissionList.html | 10 +++--- .../submissions/removeExistingFilters.html | 2 +- .../modals/submissions/saveCurrentFilter.html | 2 +- .../views/modals/view/addCommentModal.html | 18 +++++----- .../app/views/modals/view/addFileModal.html | 24 ++++++------- .../webapp/app/views/modals/view/assign.html | 2 +- .../webapp/app/views/modals/view/status.html | 2 +- .../app/views/sideboxes/activeDocument.html | 2 +- .../app/views/sideboxes/advancedFeatures.html | 8 ++--- .../furtherFilterByAssignedTo.html | 8 ++--- .../furtherFilterByCustomActions.html | 6 ++-- .../furtherFilterBy/furtherFilterByDate.html | 18 +++++----- .../furtherFilterByDegreeDate.html | 5 +-- .../furtherFilterByDegreeDateList.html | 6 ++-- .../furtherFilterByEmbargoType.html | 10 +++--- .../furtherFilterByOrganization.html | 4 +-- .../furtherFilterByOrganizationCategory.html | 6 ++-- .../furtherFilterByStatus.html | 10 +++--- .../furtherFilterBySubmissionTypeList.html | 2 +- .../furtherFilterByUmiPublication.html | 4 +-- .../app/views/sideboxes/submissionStatus.html | 4 ++- .../app/views/submission/submission.html | 6 ++-- 73 files changed, 318 insertions(+), 253 deletions(-) diff --git a/src/main/webapp/app/resources/styles/sass/app.scss b/src/main/webapp/app/resources/styles/sass/app.scss index 320b499b0a..3b91a07909 100644 --- a/src/main/webapp/app/resources/styles/sass/app.scss +++ b/src/main/webapp/app/resources/styles/sass/app.scss @@ -479,19 +479,24 @@ sidebox .heading-text { cursor: pointer; } +// Collapsed content is also made invisible, not just zero height, so that its +// controls drop out of the tab order. Visibility flips only after the collapse +// animation finishes, and immediately when expanding. .sidebox-body { display: block; background-color: #ECECEC; padding: 8px 0 1px; overflow-y: hidden; max-height: 0; - transition: max-height 0.35s ease-out; + visibility: hidden; + transition: max-height 0.35s ease-out, visibility 0s linear 0.35s; } .sidebox-body.expanded { max-height: 5000px; overflow-y: visible; - transition: max-height 0.35s ease-out; + visibility: visible; + transition: max-height 0.35s ease-out, visibility 0s; } .sidebox-sub-heading { @@ -1349,19 +1354,22 @@ input[type=color]:focus { transition: width 0.5s ease-out; } +// Hidden as well as collapsed so a closed pane's controls leave the tab order. .accordion .panel-body { max-height: 0; overflow-y: auto; /* degree codes need scroll overflow: hidden;*/ padding: 0; - -webkit-transition: max-height 0.5s ease-out; - transition: max-height 0.5s ease-out; + visibility: hidden; + -webkit-transition: max-height 0.5s ease-out, visibility 0s linear 0.5s; + transition: max-height 0.5s ease-out, visibility 0s linear 0.5s; } .accordion .panel-body.expanded { max-height: 700px; - -webkit-transition: max-height 0.5s ease-out; - transition: max-height 0.5s ease-out; + visibility: visible; + -webkit-transition: max-height 0.5s ease-out, visibility 0s; + transition: max-height 0.5s ease-out, visibility 0s; } .accordion .panel-body .remove { @@ -1604,8 +1612,9 @@ input[type=color]:focus { .further-filter-by .status-list { max-height: 0; overflow: hidden; - -webkit-transition: max-height 0.5s ease-out; - transition: max-height 0.5s ease-out; + visibility: hidden; + -webkit-transition: max-height 0.5s ease-out, visibility 0s linear 0.5s; + transition: max-height 0.5s ease-out, visibility 0s linear 0.5s; } .further-filter-by .filter:hover { @@ -1620,8 +1629,9 @@ input[type=color]:focus { .further-filter-by .submissiontype-list.expanded, .further-filter-by .status-list.expanded { max-height: 1000px; - -webkit-transition: max-height 0.5s ease-in; - transition: max-height 0.5s ease-in; + visibility: visible; + -webkit-transition: max-height 0.5s ease-in, visibility 0s; + transition: max-height 0.5s ease-in, visibility 0s; } .further-filter-by .document-level, diff --git a/src/main/webapp/app/resources/styles/sass/views/submission/_submissionDialog.scss b/src/main/webapp/app/resources/styles/sass/views/submission/_submissionDialog.scss index 8852b457c4..3e4c1b8366 100644 --- a/src/main/webapp/app/resources/styles/sass/views/submission/_submissionDialog.scss +++ b/src/main/webapp/app/resources/styles/sass/views/submission/_submissionDialog.scss @@ -116,12 +116,18 @@ ul.dialog-actions-list { color: red; } +// Closed content is made invisible too, so its controls leave the tab order and +// screen readers skip it. Visibility waits for the collapse, but not the expand. .dialog-closed { opacity: 0; max-height: 0; + visibility: hidden; + transition: max-height 0.45s ease-in-out, opacity 0.25s ease-in-out, visibility 0s linear 0.45s; } .dialog-open { opacity: 1; max-height: 5000px; + visibility: visible; + transition: max-height 0.45s ease-in-out, opacity 0.25s ease-in-out, visibility 0s; } diff --git a/src/main/webapp/app/views/admin/info/edit/input-checkbox.html b/src/main/webapp/app/views/admin/info/edit/input-checkbox.html index e3e0f1b490..9d57c0b76f 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-checkbox.html +++ b/src/main/webapp/app/views/admin/info/edit/input-checkbox.html @@ -1,7 +1,7 @@
diff --git a/src/main/webapp/app/views/admin/info/edit/input-conditional_textarea.html b/src/main/webapp/app/views/admin/info/edit/input-conditional_textarea.html index ee9fd5e0e3..56bbdeec6b 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-conditional_textarea.html +++ b/src/main/webapp/app/views/admin/info/edit/input-conditional_textarea.html @@ -7,12 +7,12 @@ ng-true-value="true" ng-false-value="false" ng-click="setConditionalTextArea(field, checked)"/> - - + +
- - + +
\ No newline at end of file diff --git a/src/main/webapp/app/views/admin/info/edit/input-contact.html b/src/main/webapp/app/views/admin/info/edit/input-contact.html index d76534bae1..6cad168bdf 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-contact.html +++ b/src/main/webapp/app/views/admin/info/edit/input-contact.html @@ -7,8 +7,8 @@ typeahead-on-select="saveWithCV(field, $item)" typeahead-loading="typeAheads.loading" /> - - + +
- - + +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-contact_select.html b/src/main/webapp/app/views/admin/info/edit/input-contact_select.html index 790d6f9f1d..eb4438114d 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-contact_select.html +++ b/src/main/webapp/app/views/admin/info/edit/input-contact_select.html @@ -1,5 +1,5 @@
-
@@ -27,5 +27,5 @@ typeahead-loading="typeAheads.loading" disabled /> - +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-date.html b/src/main/webapp/app/views/admin/info/edit/input-date.html index 07dd019575..703ee6894c 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-date.html +++ b/src/main/webapp/app/views/admin/info/edit/input-date.html @@ -1,6 +1,6 @@
- - + + - - + +
\ No newline at end of file diff --git a/src/main/webapp/app/views/admin/info/edit/input-degreedate.html b/src/main/webapp/app/views/admin/info/edit/input-degreedate.html index 7d47377306..a9fc9d0258 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-degreedate.html +++ b/src/main/webapp/app/views/admin/info/edit/input-degreedate.html @@ -1,6 +1,6 @@
- - + + - - + +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-email.html b/src/main/webapp/app/views/admin/info/edit/input-email.html index 2903ca8793..58854c9da3 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-email.html +++ b/src/main/webapp/app/views/admin/info/edit/input-email.html @@ -4,6 +4,6 @@ typeahead-wait-ms="400" ng-model="field.value" /> - - + + diff --git a/src/main/webapp/app/views/admin/info/edit/input-license.html b/src/main/webapp/app/views/admin/info/edit/input-license.html index 577aaeaa25..94ae0839cd 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-license.html +++ b/src/main/webapp/app/views/admin/info/edit/input-license.html @@ -1,5 +1,5 @@
- - + +
\ No newline at end of file diff --git a/src/main/webapp/app/views/admin/info/edit/input-orcid.html b/src/main/webapp/app/views/admin/info/edit/input-orcid.html index 407536495a..8f35e2a814 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-orcid.html +++ b/src/main/webapp/app/views/admin/info/edit/input-orcid.html @@ -1,5 +1,5 @@
- - + +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-password.html b/src/main/webapp/app/views/admin/info/edit/input-password.html index b7a27b3813..cf4573d88e 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-password.html +++ b/src/main/webapp/app/views/admin/info/edit/input-password.html @@ -1,5 +1,5 @@
- - + +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-proquest.html b/src/main/webapp/app/views/admin/info/edit/input-proquest.html index 67fc73de87..b1460f9e2e 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-proquest.html +++ b/src/main/webapp/app/views/admin/info/edit/input-proquest.html @@ -1,5 +1,5 @@
- - + +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-radio.html b/src/main/webapp/app/views/admin/info/edit/input-radio.html index 75b670a096..831fed6297 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-radio.html +++ b/src/main/webapp/app/views/admin/info/edit/input-radio.html @@ -3,7 +3,7 @@ {{word.name}}:
- - - + + -
diff --git a/src/main/webapp/app/views/admin/info/edit/input-tel.html b/src/main/webapp/app/views/admin/info/edit/input-tel.html index 407536495a..8f35e2a814 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-tel.html +++ b/src/main/webapp/app/views/admin/info/edit/input-tel.html @@ -1,5 +1,5 @@
- - + +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-text.html b/src/main/webapp/app/views/admin/info/edit/input-text.html index 2d401d885f..bd4f57848b 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-text.html +++ b/src/main/webapp/app/views/admin/info/edit/input-text.html @@ -5,6 +5,6 @@ typeahead-on-select="saveWithCV(field, $item)" ng-model="field.value" /> - - + + diff --git a/src/main/webapp/app/views/admin/info/edit/input-textarea.html b/src/main/webapp/app/views/admin/info/edit/input-textarea.html index 1efb044a56..64be5f558f 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-textarea.html +++ b/src/main/webapp/app/views/admin/info/edit/input-textarea.html @@ -1,5 +1,5 @@
- - + +
diff --git a/src/main/webapp/app/views/admin/info/edit/input-url.html b/src/main/webapp/app/views/admin/info/edit/input-url.html index 2d401d885f..bd4f57848b 100644 --- a/src/main/webapp/app/views/admin/info/edit/input-url.html +++ b/src/main/webapp/app/views/admin/info/edit/input-url.html @@ -5,6 +5,6 @@ typeahead-on-select="saveWithCV(field, $item)" ng-model="field.value" /> - - + + diff --git a/src/main/webapp/app/views/admin/list.html b/src/main/webapp/app/views/admin/list.html index 34767103bf..dc17c1b1a7 100644 --- a/src/main/webapp/app/views/admin/list.html +++ b/src/main/webapp/app/views/admin/list.html @@ -19,9 +19,9 @@

List ETDs

- diff --git a/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRules.html b/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRules.html index e5f03f19ec..bde95f2ae1 100644 --- a/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRules.html +++ b/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRules.html @@ -5,16 +5,16 @@

-

-
- +
+
+ diff --git a/src/main/webapp/app/views/admin/settings/application/lookAndFeel.html b/src/main/webapp/app/views/admin/settings/application/lookAndFeel.html index c1be2e06da..3496feff1e 100644 --- a/src/main/webapp/app/views/admin/settings/application/lookAndFeel.html +++ b/src/main/webapp/app/views/admin/settings/application/lookAndFeel.html @@ -15,6 +15,8 @@ Main Color @@ -53,6 +55,8 @@ Background Main Color @@ -85,6 +89,8 @@ Background Highlight Color @@ -114,6 +120,8 @@ Header Text Color @@ -143,6 +151,8 @@ Footer Text Color @@ -183,6 +193,8 @@ Background Main Color @@ -213,6 +225,8 @@ Background Highlight Color @@ -245,6 +259,8 @@ Text Color @@ -287,6 +303,8 @@ Background Main Color @@ -322,6 +340,8 @@ Background Highlight Color @@ -354,6 +374,8 @@ Text Color @@ -393,6 +415,8 @@ Background Main Color @@ -428,6 +452,8 @@ Background Selected Color @@ -460,6 +486,8 @@ Main Text Color @@ -489,6 +517,8 @@ Selected Text Color @@ -537,11 +567,13 @@ Header Logo

- + Current header logo
diff --git a/src/main/webapp/app/views/admin/settings/organization.html b/src/main/webapp/app/views/admin/settings/organization.html index ecd0b6e8c9..08c76d7575 100644 --- a/src/main/webapp/app/views/admin/settings/organization.html +++ b/src/main/webapp/app/views/admin/settings/organization.html @@ -14,23 +14,29 @@
  • - Manage Organization + Manage Organization
  • - Manage Workflow + Manage Workflow
  • - Email Workflow Rules + Email Workflow Rules
diff --git a/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRule.html b/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRule.html index 99dca12281..f63c77ea59 100644 --- a/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRule.html +++ b/src/main/webapp/app/views/admin/settings/organization/emailWorkflowRule.html @@ -35,13 +35,13 @@
- + - - + +
- +
- - + - +
- - +
diff --git a/src/main/webapp/app/views/admin/view.html b/src/main/webapp/app/views/admin/view.html index 56959b7391..5e9e25d664 100644 --- a/src/main/webapp/app/views/admin/view.html +++ b/src/main/webapp/app/views/admin/view.html @@ -36,9 +36,9 @@

REVIEWER NOTES

{{submission.reviewerNotes || 'none'}}
- - - + + +
diff --git a/src/main/webapp/app/views/directives/accordionPane.html b/src/main/webapp/app/views/directives/accordionPane.html index b0995bcbff..9a6a652e37 100644 --- a/src/main/webapp/app/views/directives/accordionPane.html +++ b/src/main/webapp/app/views/directives/accordionPane.html @@ -1,9 +1,9 @@
-
- - - +
Loading
+ + +
diff --git a/src/main/webapp/app/views/directives/lockingTextArea.html b/src/main/webapp/app/views/directives/lockingTextArea.html index 27d2afe91e..f2d0d7e5a4 100644 --- a/src/main/webapp/app/views/directives/lockingTextArea.html +++ b/src/main/webapp/app/views/directives/lockingTextArea.html @@ -1,23 +1,25 @@
-
{{ label }}
+
{{ label }}
- - This field is locked to prevent accidental editing, click to unlock. + + This field is locked to prevent accidental editing, click to unlock. -

+

This field is unlocked and may be edited. Leaving the editable area will save and re-lock the field.