From 0c67df8e36273b2123b74f161690db00ded40aeb Mon Sep 17 00:00:00 2001 From: Ryan Millay Date: Thu, 22 Jun 2017 09:14:14 -0400 Subject: [PATCH 1/2] resetting state when switching to ddocsOnly --- .../documents/index-results/components/queryoptions/QueryOptions.js | 1 + 1 file changed, 1 insertion(+) diff --git a/app/addons/documents/index-results/components/queryoptions/QueryOptions.js b/app/addons/documents/index-results/components/queryoptions/QueryOptions.js index 7d8b9630b..0c8058cac 100644 --- a/app/addons/documents/index-results/components/queryoptions/QueryOptions.js +++ b/app/addons/documents/index-results/components/queryoptions/QueryOptions.js @@ -42,6 +42,7 @@ export default class QueryOptions extends React.Component { } = this.props; if (!ddocsOnly && nextProps.ddocsOnly) { + resetState(); queryOptionsFilterOnlyDdocs(); } else if (ddocsOnly && !nextProps.ddocsOnly) { resetState(); From 4722c008fae68469a49104edcd769464e366376b Mon Sep 17 00:00:00 2001 From: Ryan Millay Date: Thu, 22 Jun 2017 12:35:25 -0400 Subject: [PATCH 2/2] fixing failing unit test --- app/addons/documents/__tests__/query-options.test.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/addons/documents/__tests__/query-options.test.js b/app/addons/documents/__tests__/query-options.test.js index fec4533de..fc6c6bade 100644 --- a/app/addons/documents/__tests__/query-options.test.js +++ b/app/addons/documents/__tests__/query-options.test.js @@ -68,7 +68,7 @@ describe('QueryOptions', () => { expect(spy.calledOnce).toBe(true); }); - it('calls queryOptionsFilterOnlyDdocs if ddocsOnly switches to true on new props', () => { + it('calls resetState and queryOptionsFilterOnlyDdocs if ddocsOnly switches to true on new props', () => { const spy = sinon.spy(); const queryOptionsParams = { include_docs: false @@ -76,6 +76,7 @@ describe('QueryOptions', () => { const wrapper = shallow( {}} resetPagination={() => {}} @@ -89,7 +90,7 @@ describe('QueryOptions', () => { wrapper.instance().componentWillReceiveProps({ ddocsOnly: true }); - expect(spy.calledOnce).toBe(true); + expect(spy.calledTwice).toBe(true); }); it('calls resetState if ddocsOnly switches to false on new props', () => {