From be144ef56de39206a02e383ac1cc5a6873c6678f Mon Sep 17 00:00:00 2001 From: Brian Neradt Date: Thu, 2 Sep 2021 15:44:16 +0000 Subject: [PATCH] Fix crash during raw connect failures In the case of raw open, the server_txn will generally be a nullptr. We tried to use server_txn when calling set_connect_fail, which resulted in a crash. This change simply removes the call. Note that a generic call to set_connect_fail was already called previous to calling this function. --- proxy/http/HttpSM.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc index 81ed57ec6bc..5261e08a146 100644 --- a/proxy/http/HttpSM.cc +++ b/proxy/http/HttpSM.cc @@ -1244,7 +1244,6 @@ HttpSM::state_raw_http_server_open(int event, void *data) case VC_EVENT_ERROR: case NET_EVENT_OPEN_FAILED: - t_state.set_connect_fail(server_txn->get_netvc()->lerrno); t_state.current.state = HttpTransact::OPEN_RAW_ERROR; // use this value just to get around other values t_state.hdr_info.response_error = HttpTransact::STATUS_CODE_SERVER_ERROR;