From f6e3c3dec599e380713b6d6cf05483f556fc75c8 Mon Sep 17 00:00:00 2001 From: Max Karolinskiy Date: Tue, 10 Sep 2019 10:55:44 -0400 Subject: [PATCH] Fixes lint script. Fixes brave/brave-browser#5971 Removed auth_config from our script as we don't need to pass it to devtools script any more. The failure is due to devtools change: commit 934836a6c5b1a3442db7f7197569fc1bbdcb8991 [log] [tgz] author Edward Lemur Mon Sep 09 20:16:54 2019 committer Commit Bot Mon Sep 09 20:16:54 2019 tree c6cb985aca378a2f816bb7d21a072394b1d4882a parent 1e4d70d1dd0865b0ac824beccee70d3852705dd8 [diff] git-cl: Remove unused auth configs. auth_config is a Rietveld thing, so it's not necessary in most of the code, except for triggering try bots. Bug: 1001756 Change-Id: I0f243a297b05a43a61b052ba75c5886556e81b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793018 --- scripts/lint.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/lint.py b/scripts/lint.py index d4203c4782..d80bd31221 100644 --- a/scripts/lint.py +++ b/scripts/lint.py @@ -19,7 +19,6 @@ import git_cl import git_common -import auth def main(args): """Runs cpplint on the current changelist.""" @@ -29,9 +28,7 @@ def main(args): help='Comma-separated list of cpplint\'s category-filters') parser.add_option('--project_root') parser.add_option('--base_branch') - auth.add_auth_options(parser) options, args = parser.parse_args(args) - auth_config = auth.extract_auth_config_from_options(options) # Access to a protected member _XX of a client class # pylint: disable=protected-access @@ -48,7 +45,7 @@ def main(args): previous_cwd = os.getcwd() os.chdir(settings.GetRoot()) try: - cl = git_cl.Changelist(auth_config=auth_config) + cl = git_cl.Changelist() change = cl.GetChange(git_common.get_or_create_merge_base(cl.GetBranch(), options.base_branch), None) files = [f.LocalPath() for f in change.AffectedFiles()] if not files: