From e9f9ab3a10facfdbea2ef2b01abab5d56ed50670 Mon Sep 17 00:00:00 2001 From: Anthony Tseng Date: Mon, 7 Nov 2016 09:57:13 -0500 Subject: [PATCH] Filter the lastAccessTime == 0 in urlbar suggestions fix #5183 Auditors: @bbondy, @bsclifton Test Plan: 1. Import bookmarks 2. They should not appear in urlbar suggestions until you visit them --- js/components/urlBarSuggestions.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/js/components/urlBarSuggestions.js b/js/components/urlBarSuggestions.js index f67061146c..564396838f 100644 --- a/js/components/urlBarSuggestions.js +++ b/js/components/urlBarSuggestions.js @@ -289,7 +289,8 @@ class UrlBarSuggestions extends ImmutableComponent { // status. If history is turned off, bookmarked sites will appear // in the bookmark section. return (title.toLowerCase().includes(urlLocationLower) || - location.toLowerCase().includes(urlLocationLower)) + location.toLowerCase().includes(urlLocationLower)) && + site.get('lastAccessedTime') } var historySites = props.sites.filter(historyFilter)