From 79ff595d85b241e6409a5263cc00e61689f39d9e Mon Sep 17 00:00:00 2001 From: Cezar Augusto Date: Tue, 15 Nov 2016 14:13:29 -0200 Subject: [PATCH] fix pinning topSites not respecting position Auditors: @bsclifton fix #5337 Test Plan: * Access new tab page; * Access 4-6 websites; * Pin a site. Pinning a site should add a Pin icon on top-right corner and be kept on its position (not jump); * Keep in mind the website position and reorder it to a new position; * Access another website and get back to new tab. Ensure that your last pinned website kept its position; --- js/about/newtab.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/about/newtab.js b/js/about/newtab.js index 17a502d2e8..84bea61ac0 100644 --- a/js/about/newtab.js +++ b/js/about/newtab.js @@ -66,7 +66,7 @@ class NewTabPage extends React.Component { return this.state.newTabData.getIn(['newTabDetail', 'sites']) || Immutable.List() } get pinnedTopSites () { - return this.state.newTabData.getIn(['newTabDetail', 'pinnedTopSites']) || Immutable.List().setSize(18) + return (this.state.newTabData.getIn(['newTabDetail', 'pinnedTopSites']) || Immutable.List()).setSize(18) } get ignoredTopSites () { return this.state.newTabData.getIn(['newTabDetail', 'ignoredTopSites']) || Immutable.List()