diff --git a/app/renderer/components/tabContent.js b/app/renderer/components/tabContent.js index a3eac1c0b2..1bedf822ae 100644 --- a/app/renderer/components/tabContent.js +++ b/app/renderer/components/tabContent.js @@ -147,7 +147,13 @@ class NewSessionIcon extends ImmutableComponent { } get partitionNumber () { - return this.props.tabProps.get('partitionNumber') + let partition = this.props.tabProps.get('partitionNumber') + // Persistent partitions opened by `target="_blank"` will have + // *partition-* string first, which causes bad UI. We don't need it for tabs + if (typeof partition === 'string') { + partition = partition.replace(/^partition-/i, '') + } + return partition } get partitionIndicator () { diff --git a/test/unit/app/renderer/tabContentTest.js b/test/unit/app/renderer/tabContentTest.js index 95888370f5..d36185b79e 100644 --- a/test/unit/app/renderer/tabContentTest.js +++ b/test/unit/app/renderer/tabContentTest.js @@ -264,6 +264,17 @@ describe('tabContent components', function () { ) assert.equal(wrapper.props().symbolContent, 3) }) + it('should read and show partition number for sessions with number set by opener (ex: clicking target=_blank)', function () { + const wrapper = shallow( + + ) + assert.equal(wrapper.props().symbolContent, 3) + }) it('should show max partition number even if session is bigger', function () { const wrapper = shallow(