diff --git a/app/extensions/brave/locales/en-US/app.properties b/app/extensions/brave/locales/en-US/app.properties index f231798bd6..60f2eb4cb6 100644 --- a/app/extensions/brave/locales/en-US/app.properties +++ b/app/extensions/brave/locales/en-US/app.properties @@ -242,7 +242,6 @@ importDataCloseBrowserWarning=Please make sure the selected browser is closed be importSuccess=Your data has been imported to Brave successfully. closeFirefoxWarning=Firefox must be closed during data import. Please close and try again. favoritesOrBookmarks=Favorites/Bookmarks -mergeIntoBookmarksToolbar=Merge Favorites into Bookmarks Toolbar cookies=Cookies licenseTextOk=Ok closeFirefoxWarningOk=Ok diff --git a/app/importer.js b/app/importer.js index ea584a6156..0c3235070e 100644 --- a/app/importer.js +++ b/app/importer.js @@ -21,7 +21,6 @@ const tabMessageBox = require('./browser/tabMessageBox') const {makeImmutable} = require('./common/state/immutableUtil') const tabState = require('./common/state/tabState') -var isMergeFavorites = false var isImportingBookmarks = false var hasBookmarks var importedSites @@ -31,9 +30,6 @@ exports.init = () => { } exports.importData = (selected) => { - if (selected.get('mergeFavorites')) { - isMergeFavorites = true - } if (selected.get('favorites')) { isImportingBookmarks = true const sites = AppStore.getState().get('sites') @@ -48,9 +44,6 @@ exports.importData = (selected) => { exports.importHTML = (selected) => { isImportingBookmarks = true - if (selected.get('mergeFavorites')) { - isMergeFavorites = true - } const sites = AppStore.getState().get('sites') hasBookmarks = sites.find( (site) => siteUtil.isBookmark(site) || siteUtil.isFolder(site) @@ -69,7 +62,6 @@ exports.importHTML = (selected) => { } importer.on('update-supported-browsers', (e, detail) => { - isMergeFavorites = false isImportingBookmarks = false if (BrowserWindow.getFocusedWindow()) { BrowserWindow.getFocusedWindow().webContents.send(messages.IMPORTER_LIST, detail) @@ -124,27 +116,15 @@ importer.on('add-bookmarks', (e, bookmarks, topLevelFolder) => { let pathMap = {} let sites = [] let topLevelFolderId = 0 - if (!isMergeFavorites) { - topLevelFolderId = nextFolderIdObject.id++ - sites.push({ - customTitle: topLevelFolder, - folderId: topLevelFolderId, - parentFolderId: 0, - lastAccessedTime: 0, - creationTime: (new Date()).getTime(), - tags: [siteTags.BOOKMARK_FOLDER] - }) - } else { - // Merge into existing bookmark toolbar - pathMap[topLevelFolder] = topLevelFolderId - pathMap['Bookmarks Toolbar'] = 0 // Firefox - pathMap['Bookmarks Bar'] = 0 // Chrome on mac - pathMap['Other Bookmarks'] = -1 // Chrome on mac - pathMap['Bookmarks bar'] = 0 // Chrome on win/linux - pathMap['Other bookmarks'] = -1 // Chrome on win/linux - pathMap['Bookmark Bar'] = 0 // Safari - pathMap['Links'] = 0 // Edge, IE - } + topLevelFolderId = nextFolderIdObject.id++ + sites.push({ + customTitle: siteUtil.getNextFolderName(AppStore.getState().get('sites'), topLevelFolder), + folderId: topLevelFolderId, + parentFolderId: 0, + lastAccessedTime: 0, + creationTime: (new Date()).getTime(), + tags: [siteTags.BOOKMARK_FOLDER] + }) for (let i = 0; i < bookmarks.length; ++i) { let path = bookmarks[i].path let parentFolderId = getParentFolderId(path, pathMap, sites, topLevelFolderId, nextFolderIdObject) diff --git a/app/renderer/components/importBrowserDataPanel.js b/app/renderer/components/importBrowserDataPanel.js index e844032525..c19d447e96 100644 --- a/app/renderer/components/importBrowserDataPanel.js +++ b/app/renderer/components/importBrowserDataPanel.js @@ -27,16 +27,11 @@ class ImportBrowserDataPanel extends ImmutableComponent { super() this.onToggleHistory = this.onToggleSetting.bind(this, 'history') this.onToggleFavorites = this.onToggleSetting.bind(this, 'favorites') - this.onToggleMergeFavorites = this.onToggleSetting.bind(this, 'mergeFavorites') this.onToggleCookies = this.onToggleSetting.bind(this, 'cookies') this.onImport = this.onImport.bind(this) this.onChange = this.onChange.bind(this) } onToggleSetting (setting, e) { - if (setting === 'favorites') { - this.props.importBrowserDataSelected = - this.props.importBrowserDataSelected.set('mergeFavorites', e.target.value) - } windowActions.setImportBrowserDataSelected(this.props.importBrowserDataSelected.set(setting, e.target.value)) } get browserData () { @@ -84,7 +79,6 @@ class ImportBrowserDataPanel extends ImmutableComponent { this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('index', e.target.value) this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('history', false) this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('favorites', false) - this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('mergeFavorites', false) this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('cookies', false) let importBrowserDataSelected = this.props.importBrowserDataSelected if (this.supportHistory) { @@ -92,7 +86,6 @@ class ImportBrowserDataPanel extends ImmutableComponent { } if (this.supportFavorites) { importBrowserDataSelected = importBrowserDataSelected.set('favorites', true) - importBrowserDataSelected = importBrowserDataSelected.set('mergeFavorites', true) } if (this.supportCookies) { importBrowserDataSelected = importBrowserDataSelected.set('cookies', true) @@ -108,7 +101,6 @@ class ImportBrowserDataPanel extends ImmutableComponent { } if (this.supportFavorites) { this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('favorites', true) - this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('mergeFavorites', true) } if (this.supportCookies) { this.props.importBrowserDataSelected = this.props.importBrowserDataSelected.set('cookies', true) @@ -149,14 +141,6 @@ class ImportBrowserDataPanel extends ImmutableComponent { onClick={this.onToggleFavorites} disabled={!this.supportFavorites} /> -