From 3d389f31bd7a02a388a978ebee3fd02ceb5eea4a Mon Sep 17 00:00:00 2001 From: Liunkae Date: Fri, 21 Apr 2017 00:35:37 -0500 Subject: [PATCH] Implement app.dock.downloadFinished Make the Downloads folder dock icon "bounce" when a download is complete (macOS-only). Resolves #1667 --- app/browser/electronDownloadItem.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/browser/electronDownloadItem.js b/app/browser/electronDownloadItem.js index 01b6721b87..c7749f457e 100644 --- a/app/browser/electronDownloadItem.js +++ b/app/browser/electronDownloadItem.js @@ -3,6 +3,8 @@ * You can obtain one at http://mozilla.org/MPL/2.0/. */ const downloadStates = require('../../js/constants/downloadStates') +const electron = require('electron') +const app = electron.app /** * Maps downloadId to an electron download-item @@ -11,6 +13,9 @@ const downloadMap = {} module.exports.updateElectronDownloadItem = (downloadId, item, state) => { if (state === downloadStates.INTERRUPTED || state === downloadStates.CANCELLED || state === downloadStates.COMPLETED) { + if (state === downloadStates.COMPLETED) { + app.dock.downloadFinished(item.getSavePath()) + } delete downloadMap[downloadId] } else { downloadMap[downloadId] = item