From 6896a20cea57d6985e65395c6426ff187cbe5ede Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EF=BD=81=EF=BD=99=EF=BD=95=EF=BD=8D=EF=BD=89=C2=A0=20?= =?UTF-8?q?=EF=BD=99=EF=BD=95?= Date: Thu, 27 Apr 2017 01:11:59 +0000 Subject: [PATCH] Fix stuck test "Syncing then turning it off" Auditors: @diracdeltas @bbondy --- test/lib/selectors.js | 1 + test/misc-components/syncTest.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/lib/selectors.js b/test/lib/selectors.js index e51b3a4947..22637de26c 100644 --- a/test/lib/selectors.js +++ b/test/lib/selectors.js @@ -45,6 +45,7 @@ module.exports = { allowAllCookiesOption: '[data-l10n-id="allowAllCookies"]', blockAllCookiesOption: '[data-l10n-id="blockAllCookies"]', braveryPanel: '.braveryPanel', + braveryPanelContainer: '.braveryPanelContainer', httpsEverywhereStat: '.braveryStat.redirectedResourcesStat', httpsEverywhereSwitch: '.httpsEverywhereSwitch .switchMiddle', noScriptStat: '.braveryStat.noScriptStat', diff --git a/test/misc-components/syncTest.js b/test/misc-components/syncTest.js index 03a4e0db92..2487d5e92c 100644 --- a/test/misc-components/syncTest.js +++ b/test/misc-components/syncTest.js @@ -6,7 +6,7 @@ const {newTabMode} = require('../../app/common/constants/settingsEnums') const siteTags = require('../../js/constants/siteTags') const Brave = require('../lib/brave') const Immutable = require('immutable') -const {adsBlockedControl, allowAllCookiesOption, bookmarksToolbar, braveMenu, braveryPanel, cookieControl, doneButton, fpSwitch, httpsEverywhereSwitch, navigatorBookmarked, navigatorNotBookmarked, noScriptSwitch, urlInput, removeButton, safeBrowsingSwitch, showAdsOption, syncTab, syncSwitch, bookmarkNameInput} = require('../lib/selectors') +const {adsBlockedControl, allowAllCookiesOption, bookmarksToolbar, braveMenu, braveryPanel, braveryPanelContainer, cookieControl, doneButton, fpSwitch, httpsEverywhereSwitch, navigatorBookmarked, navigatorNotBookmarked, noScriptSwitch, urlInput, removeButton, safeBrowsingSwitch, showAdsOption, syncTab, syncSwitch, bookmarkNameInput} = require('../lib/selectors') const {getTargetAboutUrl} = require('../../js/lib/appUrlUtil') const aboutBookmarksUrl = getTargetAboutUrl('about:bookmarks') const aboutHistoryUrl = getTargetAboutUrl('about:history') @@ -871,7 +871,7 @@ describe('Syncing then turning it off stops syncing', function () { .waitForVisible(fpSwitch) .click(fpSwitch) .waitUntil(checkSiteSetting(this.hostPattern1, this.siteSettingName, true)) - .keys(Brave.keys.ESCAPE) + .click(braveryPanelContainer) .pause(1000) // XXX: Wait for Sync to upload records to S3 // Sync Off - browsing activity NOT synced