From 6a9b7f6eb6fdafea5796d6f36dd692d2397344cd Mon Sep 17 00:00:00 2001 From: yan Date: Thu, 27 Apr 2017 23:55:04 +0000 Subject: [PATCH] show nothing for siteInfo on about: pages fix https://github.com/brave/browser-laptop/issues/8299 Test Plan: 1. open example.com 2. open a new tab 3. show siteInfo on example.com, then use Cmd+2 to switch to the second tab 4. no siteInfo should show on the second tab --- js/components/siteInfo.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/js/components/siteInfo.js b/js/components/siteInfo.js index f99c4cb848..c378a5b97d 100644 --- a/js/components/siteInfo.js +++ b/js/components/siteInfo.js @@ -7,6 +7,7 @@ const PropTypes = require('prop-types') const ImmutableComponent = require('../../app/renderer/components/immutableComponent') const cx = require('../lib/classSet') const {isPotentialPhishingUrl} = require('../lib/urlutil') +const {isSourceAboutUrl} = require('../lib/appUrlUtil') const Dialog = require('./dialog') const Button = require('./button') const appActions = require('../actions/appActions') @@ -66,6 +67,10 @@ class SiteInfo extends ImmutableComponent { return isPotentialPhishingUrl(this.props.frameProps.getIn(['location'])) } render () { + if (isSourceAboutUrl(this.location)) { + return null + } + // Figure out the partition info display let l10nArgs = { partitionNumber: this.partitionNumber