From e8950ca2b41c459fddbc1b8f12061e2c934eb5ea Mon Sep 17 00:00:00 2001 From: Josiah Keller Date: Fri, 28 Apr 2017 00:41:10 -0400 Subject: [PATCH] Make up/down arrow keys wrap to other end in urlbar suggestions Fix #7682 --- app/renderer/reducers/urlBarSuggestionsReducer.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/renderer/reducers/urlBarSuggestionsReducer.js b/app/renderer/reducers/urlBarSuggestionsReducer.js index 7ee16cade2..94ef68fb40 100644 --- a/app/renderer/reducers/urlBarSuggestionsReducer.js +++ b/app/renderer/reducers/urlBarSuggestionsReducer.js @@ -328,6 +328,8 @@ const urlBarSuggestionsReducer = (state, action) => { state = state.setIn(selectedIndexPath, 0) } else if (selectedIndex > 0) { state = state.setIn(selectedIndexPath, selectedIndex - 1) + } else { + state = state.setIn(selectedIndexPath, suggestionList.size - 1) } state = updateUrlSuffix(state, state.getIn(activeFrameStatePath(state).concat(['navbar', 'urlbar', 'suggestions', 'suggestionList']), suggestionList)) break @@ -341,6 +343,8 @@ const urlBarSuggestionsReducer = (state, action) => { state = state.setIn(selectedIndexPath, 0) } else if (selectedIndex < suggestionList.size - 1) { state = state.setIn(selectedIndexPath, selectedIndex + 1) + } else if (selectedIndex === suggestionList.size - 1) { + state = state.setIn(selectedIndexPath, 0) } state = updateUrlSuffix(state, state.getIn(activeFrameStatePath(state).concat(['navbar', 'urlbar', 'suggestions', 'suggestionList']), suggestionList)) break