From 5c69c4907eb97875dbdbf2b453112cf4e561ef75 Mon Sep 17 00:00:00 2001 From: Nejc Zdovc Date: Fri, 6 Mar 2020 09:50:19 +0100 Subject: [PATCH 1/6] Create PR.md --- PR.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 PR.md diff --git a/PR.md b/PR.md new file mode 100644 index 0000000..0e565dd --- /dev/null +++ b/PR.md @@ -0,0 +1 @@ +# Checklist for PR in [brave-core](https://github.com/brave/brave-core) From 2624d440fa099674189de0c27045a1d125f8cfdd Mon Sep 17 00:00:00 2001 From: Nejc Zdovc Date: Fri, 6 Mar 2020 10:04:07 +0100 Subject: [PATCH 2/6] Update PR.md --- PR.md | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/PR.md b/PR.md index 0e565dd..4da683f 100644 --- a/PR.md +++ b/PR.md @@ -1 +1,21 @@ -# Checklist for PR in [brave-core](https://github.com/brave/brave-core) +# Everything around PR's in [brave-core](https://github.com/brave/brave-core) + + +## Checklist for creating PR +- how to handle CI failure (with skip labels) +- draft PR +- skip labels in general +- checklist that needs to be done +- assigning milestones +- uplifts +- commits (squashing and keeping clean history) +- review request via our tag +- wait for CI before approving +- if you change code ask for re-review (no automatic review dismissal) +- you are responsible for PR to be reviewed +- always check CI, if CI failed on not related things add a note to the PR + + +## Checklist for reviewing PR +- make sure that it follows our coding standard and chromium ones (https://google.github.io/styleguide/cppguide.html) +- make sure that CI passed (yes it can take multiple tries) From 3b874f76fda4ccfaeed8e4bbb22cd2ab799513fd Mon Sep 17 00:00:00 2001 From: Nejc Zdovc Date: Fri, 6 Mar 2020 13:26:15 +0100 Subject: [PATCH 3/6] Update PR.md --- PR.md | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/PR.md b/PR.md index 4da683f..b7ffa7b 100644 --- a/PR.md +++ b/PR.md @@ -2,20 +2,26 @@ ## Checklist for creating PR +- move issue that this PR is resolving in In Progress column on global board - how to handle CI failure (with skip labels) -- draft PR +- draft PR (try to do it as soon as possible, don't wait for everything to be done so that you don't loose work) - skip labels in general - checklist that needs to be done - assigning milestones - uplifts - commits (squashing and keeping clean history) -- review request via our tag +- review request via our tag (move it in Review column on global board) - wait for CI before approving - if you change code ask for re-review (no automatic review dismissal) - you are responsible for PR to be reviewed -- always check CI, if CI failed on not related things add a note to the PR - +- always check CI (yes it can take multiple tries), if CI failed on not related things add a note to the PR ## Checklist for reviewing PR -- make sure that it follows our coding standard and chromium ones (https://google.github.io/styleguide/cppguide.html) -- make sure that CI passed (yes it can take multiple tries) +- it follows our coding standard and chromium ones (https://google.github.io/styleguide/cppguide.html) +- CI passed or make sure that there is a note about failure +- it has test plan in the PR +- it has `feature/rewards` label +- it has `QA/Yes` or `QA/No` on the issue that this PR is resolving +- always go through test plan locally so that you can confirm that is working as expecting +- try to find edge cases that PR could introduce +- if you have questions contact creator and go through the PR with him From 0de2e4598d81a093edf1eb8e514c07ae3e356d2c Mon Sep 17 00:00:00 2001 From: Nejc Zdovc Date: Fri, 6 Mar 2020 13:36:37 +0100 Subject: [PATCH 4/6] Update PR.md --- PR.md | 1 + 1 file changed, 1 insertion(+) diff --git a/PR.md b/PR.md index b7ffa7b..dcda7f5 100644 --- a/PR.md +++ b/PR.md @@ -2,6 +2,7 @@ ## Checklist for creating PR +- every PR needs to have an issue that is resolving, sometimes PR resolves multiple issues - move issue that this PR is resolving in In Progress column on global board - how to handle CI failure (with skip labels) - draft PR (try to do it as soon as possible, don't wait for everything to be done so that you don't loose work) From fbe11e24ab6700e808a0024f6fba6f4b58ba67a0 Mon Sep 17 00:00:00 2001 From: Nejc Zdovc Date: Sun, 8 Mar 2020 10:15:09 +0100 Subject: [PATCH 5/6] Update PR.md --- PR.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PR.md b/PR.md index dcda7f5..742b543 100644 --- a/PR.md +++ b/PR.md @@ -15,7 +15,9 @@ - wait for CI before approving - if you change code ask for re-review (no automatic review dismissal) - you are responsible for PR to be reviewed +- do not add PR to any projects - always check CI (yes it can take multiple tries), if CI failed on not related things add a note to the PR +- add `feature/rewards` label ## Checklist for reviewing PR - it follows our coding standard and chromium ones (https://google.github.io/styleguide/cppguide.html) From 16ea09a933451af8e7535569628a14dcce9f744b Mon Sep 17 00:00:00 2001 From: Nejc Zdovc Date: Sun, 8 Mar 2020 10:17:01 +0100 Subject: [PATCH 6/6] Update PR.md --- PR.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PR.md b/PR.md index 742b543..2adfccf 100644 --- a/PR.md +++ b/PR.md @@ -17,7 +17,7 @@ - you are responsible for PR to be reviewed - do not add PR to any projects - always check CI (yes it can take multiple tries), if CI failed on not related things add a note to the PR -- add `feature/rewards` label +- only add `feature/rewards` label to the PR (except of skip labels of course), everything else should be labeled in the issue ## Checklist for reviewing PR - it follows our coding standard and chromium ones (https://google.github.io/styleguide/cppguide.html)