App
" }, + }, + ], + timestamp: 1, + }, + { + role: "user", + content: [ + { + type: "tool_result", + callId: "call-1", + content: [{ type: "text", text: "wrote designs/index.html" }], + }, + ], + timestamp: 2, + }, + replyTurn, + ]; + const cycleSource = { + sourceId: "anthropic", + provider: "anthropic", + model: "claude-sonnet-4-6", + }; + const heldUnchecked = await decideWithTurns(uncheckedTurns, { + type: "inference.done", + turn: replyTurn, + usage: state.tokenUsage, + source: cycleSource, + }); + expect(heldUnchecked.some((action) => action.type === "compact")).toBe(true); + const reInferUnchecked = await decideWithTurns(uncheckedTurns, { + type: "compaction.done", + compactor: "@corbits-builder/drop-degenerate-turn", + reason: "reply before done", + }); + const infer1 = reInferUnchecked.find((action) => action.type === "infer"); + const prompt1 = + infer1?.type === "infer" && typeof infer1.options?.systemPrompt === "string" + ? infer1.options.systemPrompt + : undefined; + expect(prompt1).toContain( + "Files changed after the last passing check-app, so the work is not done yet.", + ); + + // 2. Reply when no files changed yet and no design option was filed -> held by fileBeforeDone. + const unfiledTurns: ConversationTurn[] = [ + { + role: "user", + content: [{ type: "text", text: "Design the app." }], + timestamp: 0, + }, + replyTurn, + ]; + const heldUnfiled = await decideWithTurns(unfiledTurns, { + type: "inference.done", + turn: replyTurn, + usage: state.tokenUsage, + source: cycleSource, + }); + expect(heldUnfiled.some((action) => action.type === "compact")).toBe(true); + const reInferUnfiled = await decideWithTurns(unfiledTurns, { + type: "compaction.done", + compactor: "@corbits-builder/drop-degenerate-turn", + reason: "reply before done", + }); + const infer2 = reInferUnfiled.find((action) => action.type === "infer"); + const prompt2 = + infer2?.type === "infer" && typeof infer2.options?.systemPrompt === "string" + ? infer2.options.systemPrompt + : undefined; + expect(prompt2).toContain( + "The design option is not filed yet; check_design or file_design_option files it.", + ); + + // 3. Passing check_design that auto-filed the design option -> reply is accepted without extra turn. + const autoFiledTurns: ConversationTurn[] = [ + ...uncheckedTurns.slice(0, -1), + { + role: "assistant", + content: [ + { + type: "tool_call", + id: "call-check", + name: CHECK_DESIGN_TOOL, + arguments: {}, + }, + ], + timestamp: 3, + }, + { + role: "user", + content: [ + { + type: "tool_result", + callId: "call-check", + content: [ + { + type: "text", + text: 'check passed: served .builder/designs\nFiled design_option: {"artifactId":"design-1","kind":"design_option","version":1,"sha256":"a"}', + }, + ], + }, + ], + timestamp: 4, + }, + replyTurn, + ]; + const accepted = await decideWithTurns(autoFiledTurns, { + type: "inference.done", + turn: replyTurn, + usage: state.tokenUsage, + source: cycleSource, + }); + expect(accepted.some((action) => action.type === "reply")).toBe(true); +}); + +test("check_design validates DESIGN.md and .dark in styles.css and auto-files the design option on pass", async () => { + const starter = designStarterFiles(); + const modernSleek = designThemes()["modern-sleek"]!; + const workspace = await realpath( + await mkdtemp(join(tmpdir(), "sb-design-autocheck-")), + ); + const check = createDesignCheck(workspace, async () => ({ + exitCode: 0, + output: + "check passed: served .builder/designs and opened /, /#/home at 1280 and 390 px with no errors", + })); + try { + for (const [path, text] of Object.entries(starter)) { + const target = join(workspace, path); + await mkdir(dirname(target), { recursive: true }); + await writeFile(target, text); + } + const deployment = { + source: { + kind: "asset" as const, + assetId: "asset", + package: { format: "tarball" as const }, + }, + entry: "entry", + pin: "@corbits-builder/designer@1.0.0", + sourceOfferingIds: ["offering"], + defaultSourceOfferingId: "offering", + }; + let postCount = 0; + const fetch = async (path: string, init: RequestInit) => { + if (path === "/api/workflow-project-scope") + return Response.json({ + tenantId: "tenant", + projectId: "project", + domain: "example.invalid", + role: "designer", + workflows: { + writer: deployment, + reviewer: deployment, + coder: deployment, + designer: deployment, + }, + openNetwork: false, + build: { + assetDirectory: "/assets", + browserCli: "/browser", + childPath: "/child", + dependencyRoots: ["/deps"], + ripgrepPath: "/rg", + runtimeVersion: "1.0.0", + }, + }); + if (path === "/api/tenants/tenant/projects/project/artifacts") { + postCount += 1; + const body = JSON.parse(String(init.body)) as { title: string }; + return Response.json({ + artifact: { + artifactId: "design-1", + kind: "design_option", + title: body.title, + version: postCount, + sha256: "a".repeat(64), + }, + }); + } + return Response.json({ code: "unexpected_route" }, { status: 404 }); + }; + const capabilities = { + resolve: () => ({ resolve: async () => ({ kind: "http", fetch }) }), + } as unknown as RuntimeCapabilities; + const tools = createDesignTools()({ + toolCwd: workspace, + capabilities, + } as never); + const signal = new AbortController().signal; + + // 1. Starter DESIGN.md with template placeholders fails check_design even when check-app exits 0. + const placeholderCheck = await check.current(signal); + expect(placeholderCheck.passed).toBe(false); + expect(placeholderCheck.checklist).toContain( + "check failed: invalid_design: DESIGN.md still has", + ); + expect(postCount).toBe(0); + + // 2. Valid DESIGN.md but styles.css missing .dark fails check_design with the exact token error. + await writeFile( + join(workspace, ".builder", "DESIGN.md"), + modernSleek["DESIGN.md"]!, + ); + const stylesWithoutDark = modernSleek["designs/styles.css"]!.replace( + /\.dark\s*\{[^}]*\}/, + "", + ); + await writeFile( + join(workspace, ".builder", "designs", "styles.css"), + stylesWithoutDark, + ); + const missingDarkCheck = await check.current(signal); + expect(missingDarkCheck.passed).toBe(false); + expect(missingDarkCheck.checklist).toContain( + "check failed: invalid_design: styles.css has no .dark rule", + ); + expect(postCount).toBe(0); + + // 3. Restoring valid styles.css makes check_design pass AND auto-file the design option. + await writeFile( + join(workspace, ".builder", "designs", "styles.css"), + modernSleek["designs/styles.css"]!, + ); + const passedCheck = await check.current(signal); + expect(passedCheck.passed).toBe(true); + expect(passedCheck.checklist).toContain("check passed:"); + expect(passedCheck.checklist).toContain("Filed design_option:"); + expect(postCount).toBe(1); + + // 4. Calling file_design_option on the same unchanged files reuses the filed receipt without a second POST. + const filedResult = await tools.run( + { id: "call-file", name: "file_design_option", arguments: {} }, + signal, + ); + expect(filedResult.isError).toBeUndefined(); + expect(postCount).toBe(1); + expect(JSON.parse(String(filedResult.content))).toMatchObject({ + artifactId: "design-1", + kind: "design_option", + version: 1, + }); + } finally { + check.dispose(); + await rm(workspace, { recursive: true, force: true }); + } +}); diff --git a/apps/hub/src/workflows/compaction.ts b/apps/hub/src/workflows/compaction.ts index b6c3ae3d..c1ecd856 100644 --- a/apps/hub/src/workflows/compaction.ts +++ b/apps/hub/src/workflows/compaction.ts @@ -257,7 +257,7 @@ const backoffRetryPolicy: RetryPolicy = ({ error, attempt, elapsedMs }) => { !TRANSIENT_ERRORS.has(error.category) || delayMs === undefined || (error.category === "timeout" && attempt > TIMEOUT_RETRIES) || - elapsedMs > RETRY_BUDGET_MS || + (error.category !== "timeout" && elapsedMs > RETRY_BUDGET_MS) || (retryAfterMs !== undefined && retryAfterMs > MAX_RETRY_AFTER_MS) ) return { kind: "abort" }; @@ -344,9 +344,9 @@ function taskCalls(turns: readonly ConversationTurn[]) { function unchecked(turns: readonly ConversationTurn[]): boolean { for (const call of taskCalls(turns)) { if (call.name === "run_shell" && /check-app/.test(call.command)) - return !/check passed/.test(call.result); + return call.isError || !/check passed/.test(call.result); if (call.name === CHECK_DESIGN_TOOL) - return !/check passed/.test(call.result); + return call.isError || !/check passed/.test(call.result); if (call.name === "file_design_option") return call.isError; if ( WRITE_TOOLS.has(call.name) || @@ -357,14 +357,43 @@ function unchecked(turns: readonly ConversationTurn[]): boolean { return false; } +const filed = (call: ReturnType',
+ '
",
+ "Hello, world
', + "',
+ '
",
+ "