From 94cbc3dcc4df8ae835738d678795aea861f62f03 Mon Sep 17 00:00:00 2001 From: Paul Cochrane Date: Fri, 12 Jun 2015 12:59:33 +0200 Subject: [PATCH 1/5] Add space after =cut statement This corrects the 'Spurious text after =cut' errors found by podchecker. --- lib/SQL/Translator/Generator/DDL/PostgreSQL.pm | 1 + lib/SQL/Translator/Generator/DDL/SQLite.pm | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/SQL/Translator/Generator/DDL/PostgreSQL.pm b/lib/SQL/Translator/Generator/DDL/PostgreSQL.pm index cdf5049d9..109eb3cf9 100644 --- a/lib/SQL/Translator/Generator/DDL/PostgreSQL.pm +++ b/lib/SQL/Translator/Generator/DDL/PostgreSQL.pm @@ -10,6 +10,7 @@ engine. I =cut + use Moo; has quote_chars => ( diff --git a/lib/SQL/Translator/Generator/DDL/SQLite.pm b/lib/SQL/Translator/Generator/DDL/SQLite.pm index 621ff8a86..afce4b3ab 100644 --- a/lib/SQL/Translator/Generator/DDL/SQLite.pm +++ b/lib/SQL/Translator/Generator/DDL/SQLite.pm @@ -10,6 +10,7 @@ engine. I =cut + use Moo; has quote_chars => (is=>'ro', default=>sub { +[qw(" ")] } ); From 4646fcaef0ba8b278898d14def554359a492de3d Mon Sep 17 00:00:00 2001 From: Paul Cochrane Date: Fri, 12 Jun 2015 13:06:43 +0200 Subject: [PATCH 2/5] Remove empty =over blocks This removes the 'No items in =over' warning from podchecker --- lib/SQL/Translator/Producer/DiaUml.pm | 4 ---- lib/SQL/Translator/Producer/Latex.pm | 4 ---- 2 files changed, 8 deletions(-) diff --git a/lib/SQL/Translator/Producer/DiaUml.pm b/lib/SQL/Translator/Producer/DiaUml.pm index 187bd611c..cdb258134 100644 --- a/lib/SQL/Translator/Producer/DiaUml.pm +++ b/lib/SQL/Translator/Producer/DiaUml.pm @@ -28,10 +28,6 @@ automatically arrange them horizontally or vertically. =head2 Producer Args -=over 4 - -=back - =cut use strict; diff --git a/lib/SQL/Translator/Producer/Latex.pm b/lib/SQL/Translator/Producer/Latex.pm index 87369c253..5d4b3dcc0 100644 --- a/lib/SQL/Translator/Producer/Latex.pm +++ b/lib/SQL/Translator/Producer/Latex.pm @@ -28,10 +28,6 @@ automatically arrange them horizontally or vertically. =head2 Producer Args -=over 4 - -=back - =cut use strict; From c6d070fbdec49f8a88c2424f6fbff3694822468d Mon Sep 17 00:00:00 2001 From: Paul Cochrane Date: Fri, 12 Jun 2015 13:15:00 +0200 Subject: [PATCH 3/5] Escape slash char inside POD link Inside POD links (L<>), one needs to escape special characters such as / and |. This change replaces the slash char in the link with its relevant POD escape: E. Admittedly this is hard to read in the plain text, however the generated link correctly jumps to its target and podchecker doesn't complain so much. --- lib/SQL/Translator.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/SQL/Translator.pm b/lib/SQL/Translator.pm index 1f0c636d0..2857f381c 100644 --- a/lib/SQL/Translator.pm +++ b/lib/SQL/Translator.pm @@ -1104,7 +1104,7 @@ or unified-diff formatted patches, GitHub pull requests, or plain bug reports either via RT or the Mailing list. Contributors are generally granted access to the official repository after their first several patches pass successful review. Don't hesitate to -L us with any further questions you may +LSUPPORT> us with any further questions you may have. This project is maintained in a git repository. The code and related tools are From eef0c99e883ddc35e38db11dcba0661a2182c2ed Mon Sep 17 00:00:00 2001 From: Paul Cochrane Date: Fri, 12 Jun 2015 13:56:14 +0200 Subject: [PATCH 4/5] Add a DESCRIPTION to SQL::Translator::Filter::Names --- lib/SQL/Translator/Filter/Names.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/SQL/Translator/Filter/Names.pm b/lib/SQL/Translator/Filter/Names.pm index 7643e6e1b..991a774e0 100644 --- a/lib/SQL/Translator/Filter/Names.pm +++ b/lib/SQL/Translator/Filter/Names.pm @@ -102,6 +102,8 @@ L, L =head1 BUGS =head1 TODO +Tweak the names of schema objects by providing functions to filter the names +from the given into the desired forms. =over 4 From 5f8797a913c8ed05234d3b436df48b58789782b4 Mon Sep 17 00:00:00 2001 From: Paul Cochrane Date: Fri, 12 Jun 2015 14:49:40 +0200 Subject: [PATCH 5/5] Replace sectioned links with C<> formatting Using L<> for sectioned links (e.g. L) is deprecated. The Pod::Checker docs state that "POD hyperlinks may point to POD documents only." This change also removes a warning from podchecker. --- lib/SQL/Translator/Filter/DefaultExtra.pm | 2 +- lib/SQL/Translator/Filter/Globals.pm | 2 +- lib/SQL/Translator/Filter/Names.pm | 2 +- lib/SQL/Translator/Producer/XML/SQLFairy.pm | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/SQL/Translator/Filter/DefaultExtra.pm b/lib/SQL/Translator/Filter/DefaultExtra.pm index 4549d4130..49e046d70 100644 --- a/lib/SQL/Translator/Filter/DefaultExtra.pm +++ b/lib/SQL/Translator/Filter/DefaultExtra.pm @@ -67,7 +67,7 @@ if you want to set lots of things, use lots of filters! =head1 SEE ALSO -L, L +C, L =head1 BUGS diff --git a/lib/SQL/Translator/Filter/Globals.pm b/lib/SQL/Translator/Filter/Globals.pm index 497e40f57..f4de7fa03 100644 --- a/lib/SQL/Translator/Filter/Globals.pm +++ b/lib/SQL/Translator/Filter/Globals.pm @@ -147,7 +147,7 @@ filter. =head1 SEE ALSO -L, L +C, L =head1 BUGS diff --git a/lib/SQL/Translator/Filter/Names.pm b/lib/SQL/Translator/Filter/Names.pm index 991a774e0..dec2fa217 100644 --- a/lib/SQL/Translator/Filter/Names.pm +++ b/lib/SQL/Translator/Filter/Names.pm @@ -97,7 +97,7 @@ __END__ =head1 SEE ALSO -L, L +C, L =head1 BUGS diff --git a/lib/SQL/Translator/Producer/XML/SQLFairy.pm b/lib/SQL/Translator/Producer/XML/SQLFairy.pm index 446b60e0e..73411f6c2 100644 --- a/lib/SQL/Translator/Producer/XML/SQLFairy.pm +++ b/lib/SQL/Translator/Producer/XML/SQLFairy.pm @@ -396,7 +396,7 @@ Mark Addison Emark.addison@itn.co.ukE. =head1 SEE ALSO -L, L, L, +C, L, L, L, L. =cut