From 34ebb22edc81a6b4cc9f9a8cda11613ce855d3ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Loraine=20Gu=C3=A9guen?= Date: Thu, 27 Apr 2017 14:49:21 +0200 Subject: [PATCH 1/4] DE_matrices needed only if running go_enrichment. --- tools/trinity/analyze_diff_expr.xml | 33 ++++++++++++++------------------- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/tools/trinity/analyze_diff_expr.xml b/tools/trinity/analyze_diff_expr.xml index c611d7db9..c07c8809a 100644 --- a/tools/trinity/analyze_diff_expr.xml +++ b/tools/trinity/analyze_diff_expr.xml @@ -15,10 +15,12 @@ ln -s "${input}" "${re.sub('[^\w\-_.]', '_', input.element_identifier)}.DE_results" && #end for - #for $DE_matrix in $DE_matrices - ln -s "${DE_matrix}" "${re.sub('[^\w\-_.]', '_', DE_matrix.element_identifier)}.count_matrix" - && - #end for + #if str( $additional_params.GO_enrichment.examine_GO_enrichment ) == "yes": + #for $DE_matrix in $DE_matrices + ln -s "${DE_matrix}" "${re.sub('[^\w\-_.]', '_', DE_matrix.element_identifier)}.count_matrix" + && + #end for + #end if analyze_diff_expr.pl --matrix "${matrix}" @@ -48,7 +50,6 @@ -
@@ -63,6 +64,7 @@ + @@ -98,13 +100,6 @@ - - - - - - - @@ -133,16 +128,16 @@ - - - - - - -
+ + + + + + + From 5fe7b47489146178533f2dcf00812ed75ccf1a29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Loraine=20Gu=C3=A9guen?= Date: Thu, 27 Apr 2017 15:56:08 +0200 Subject: [PATCH 2/4] DE_matrices needed only if running go_enrichment. Tests passed. --- tools/trinity/analyze_diff_expr.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/trinity/analyze_diff_expr.xml b/tools/trinity/analyze_diff_expr.xml index c07c8809a..7fe8c34e0 100644 --- a/tools/trinity/analyze_diff_expr.xml +++ b/tools/trinity/analyze_diff_expr.xml @@ -16,7 +16,7 @@ && #end for #if str( $additional_params.GO_enrichment.examine_GO_enrichment ) == "yes": - #for $DE_matrix in $DE_matrices + #for $DE_matrix in $additional_params.GO_enrichment.DE_matrices ln -s "${DE_matrix}" "${re.sub('[^\w\-_.]', '_', DE_matrix.element_identifier)}.count_matrix" && #end for From 35998623fe7dbd4ab05db98d192dc2fac69d2683 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Loraine=20Gu=C3=A9guen?= Date: Thu, 11 May 2017 10:56:19 +0200 Subject: [PATCH 3/4] Improve handling of input file names for DE_results and count_matrix files. Adjust file names in tests consequently. Add test for DE_results input files with non-standard names. Keep '.subset' in the name generated for extracted_DE_genes output files. --- tools/trinity/analyze_diff_expr.xml | 73 ++++++++++++++++++++++++++++--------- 1 file changed, 56 insertions(+), 17 deletions(-) diff --git a/tools/trinity/analyze_diff_expr.xml b/tools/trinity/analyze_diff_expr.xml index 7fe8c34e0..5124d11c9 100644 --- a/tools/trinity/analyze_diff_expr.xml +++ b/tools/trinity/analyze_diff_expr.xml @@ -1,4 +1,4 @@ - + from a Trinity assembly macros.xml @@ -12,12 +12,20 @@ ## DE results input files must be in the working directory and have suffix .DE_results #import re #for $input in $DE_results - ln -s "${input}" "${re.sub('[^\w\-_.]', '_', input.element_identifier)}.DE_results" + #if re.search('.DE_results$',input.element_identifier) + ## General case, where DE results files have been previously generated by run_de_analysis.pl + ln -s "${input}" "${re.sub('[^\w\-_.]', '_', input.element_identifier)}" + #else + ## Particular case, where DE results files have non-standard names + ln -s "${input}" "${re.sub('[^\w\-_.]', '_', input.element_identifier)}.DE_results" + #end if && #end for #if str( $additional_params.GO_enrichment.examine_GO_enrichment ) == "yes": + ## DE matrix input files must be in the working directory and have the same name as DE results input files, but replacing suffix .DE_results by suffix .count_matrix #for $DE_matrix in $additional_params.GO_enrichment.DE_matrices - ln -s "${DE_matrix}" "${re.sub('[^\w\-_.]', '_', DE_matrix.element_identifier)}.count_matrix" + ## Handle general case, where DE results files and DE matrix files have been previously generated by run_de_analysis.pl + ln -s "${DE_matrix}" "${re.sub('[^\w\-_.]', '_', DE_matrix.element_identifier)}" && #end for #end if @@ -64,7 +72,7 @@ - + @@ -73,7 +81,7 @@ - + @@ -90,23 +98,24 @@ + - - - + + + - - - - - - + + + + + + @@ -118,6 +127,7 @@ + @@ -126,6 +136,35 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
@@ -133,9 +172,9 @@ - - - + + + From bd508175724d134aa147fd3a11e89741b370db85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Loraine=20Gu=C3=A9guen?= Date: Thu, 11 May 2017 11:56:39 +0200 Subject: [PATCH 4/4] Remove unnecessary bioconductor-go.db requirement. This conda package is already installed with bioconductor-goseq. --- tools/trinity/analyze_diff_expr.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/trinity/analyze_diff_expr.xml b/tools/trinity/analyze_diff_expr.xml index 5124d11c9..c1a1df143 100644 --- a/tools/trinity/analyze_diff_expr.xml +++ b/tools/trinity/analyze_diff_expr.xml @@ -6,7 +6,6 @@ bioconductor-qvalue bioconductor-goseq - bioconductor-go.db