From 95340ecd538601fd688a7b2eaac06774e7501dd9 Mon Sep 17 00:00:00 2001 From: wlycdgr Date: Thu, 14 Nov 2019 14:31:29 -0500 Subject: [PATCH 1/4] Fix name fields of hub plus promo modal pings --- app/hub/Views/HomeView/HomeViewContainer.jsx | 6 +++--- manifest.json | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/hub/Views/HomeView/HomeViewContainer.jsx b/app/hub/Views/HomeView/HomeViewContainer.jsx index a69f9c03f..6eccd89b0 100644 --- a/app/hub/Views/HomeView/HomeViewContainer.jsx +++ b/app/hub/Views/HomeView/HomeViewContainer.jsx @@ -71,7 +71,7 @@ class HomeViewContainer extends Component { sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {}); - sendMessage('ping', 'promo_modals_select_basic_hub'); + sendMessage('SEND_PING', 'promo_modals_select_basic_hub'); } /** @@ -85,7 +85,7 @@ class HomeViewContainer extends Component { sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {}); - sendMessage('ping', 'promo_modals_select_plus_hub'); + sendMessage('SEND_PING', 'promo_modals_select_plus_hub'); window.open(`https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=intro_hub`, '_blank'); } @@ -112,7 +112,7 @@ class HomeViewContainer extends Component { const showPromoModal = !isPlus && !plus_promo_modal_shown; if (showPromoModal) { - sendMessage('ping', 'promo_modals_show_plus_choice_hub'); + sendMessage('SEND_PING', 'promo_modals_show_plus_choice_hub'); } return ( diff --git a/manifest.json b/manifest.json index e1049ff13..89c2645fc 100644 --- a/manifest.json +++ b/manifest.json @@ -1,5 +1,7 @@ { "manifest_version": 2, + "debug": true, + "log": true, "applications": { "gecko": { "id": "firefox@ghostery.com", @@ -100,4 +102,4 @@ "app/images/*", "dist/css/rewards_styles.css" ] -} \ No newline at end of file +} From 23768258988d95474d32ea2bbc26f0013d811153 Mon Sep 17 00:00:00 2001 From: wlycdgr Date: Fri, 15 Nov 2019 11:00:41 -0500 Subject: [PATCH 2/4] Remove hub initial plus promo modal pings --- app/hub/Views/HomeView/HomeViewContainer.jsx | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app/hub/Views/HomeView/HomeViewContainer.jsx b/app/hub/Views/HomeView/HomeViewContainer.jsx index 6eccd89b0..b9edcd753 100644 --- a/app/hub/Views/HomeView/HomeViewContainer.jsx +++ b/app/hub/Views/HomeView/HomeViewContainer.jsx @@ -70,8 +70,6 @@ class HomeViewContainer extends Component { this.props.actions.markPlusPromoModalShown(); sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {}); - - sendMessage('SEND_PING', 'promo_modals_select_basic_hub'); } /** @@ -85,8 +83,6 @@ class HomeViewContainer extends Component { sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {}); - sendMessage('SEND_PING', 'promo_modals_select_plus_hub'); - window.open(`https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=intro_hub`, '_blank'); } @@ -111,9 +107,6 @@ class HomeViewContainer extends Component { }; const showPromoModal = !isPlus && !plus_promo_modal_shown; - if (showPromoModal) { - sendMessage('SEND_PING', 'promo_modals_show_plus_choice_hub'); - } return (
From 95323a7f722cbeec55e2d12a025410337273d369 Mon Sep 17 00:00:00 2001 From: wlycdgr Date: Fri, 15 Nov 2019 11:03:51 -0500 Subject: [PATCH 3/4] Remove initial panel plus promo metrics pings --- app/panel/components/Panel.jsx | 5 ----- 1 file changed, 5 deletions(-) diff --git a/app/panel/components/Panel.jsx b/app/panel/components/Panel.jsx index 8cb6ed133..45f5de0e4 100644 --- a/app/panel/components/Panel.jsx +++ b/app/panel/components/Panel.jsx @@ -235,8 +235,6 @@ class Panel extends React.Component { // we do not mark the choice-required initial plus promo as 'seen' until // the user has clicked Select Basic or Select Plus sendMessage('promoModals.sawPlusPromo', {}); - - sendMessage('ping', 'promo_modals_select_basic_panel'); }; /** @@ -250,8 +248,6 @@ class Panel extends React.Component { // the user has clicked Select Basic or Select Plus sendMessage('promoModals.sawPlusPromo', {}); - sendMessage('ping', 'promo_modals_select_plus_panel'); - const url = `https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=in_app`; sendMessage('openNewTab', { url, @@ -324,7 +320,6 @@ class Panel extends React.Component { } // promoModal === 'plus_initial' - sendMessage('ping', 'promo_modals_show_plus_choice_panel'); return ( Date: Fri, 15 Nov 2019 11:25:04 -0500 Subject: [PATCH 4/4] Remove unused pings from Metrics#ping --- src/classes/Metrics.js | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/classes/Metrics.js b/src/classes/Metrics.js index 7533ba295..7632cefc5 100644 --- a/src/classes/Metrics.js +++ b/src/classes/Metrics.js @@ -285,14 +285,8 @@ class Metrics { // Promo Modals - Ghostery 8.4.4+ case 'promo_modals_insights_upgrade_cta': case 'promo_modals_plus_upgrade_cta': - case 'promo_modals_select_plus_panel': - case 'promo_modals_select_basic_panel': - case 'promo_modals_select_plus_hub': - case 'promo_modals_select_basic_hub': case 'promo_modals_decline_insights_upgrade': case 'promo_modals_decline_plus_upgrade': - case 'promo_modals_show_plus_choice_hub': - case 'promo_modals_show_plus_choice_panel': case 'promo_modals_show_upgrade_plus': case 'promo_modals_show_insights': this._sendReq(type, ['all']);