From 5585ad682ffb2c255edfa0106af27640afc874b7 Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 13 Jul 2020 14:28:13 -0400 Subject: [PATCH 1/4] Fix detailed view --- app/panel/components/AccountSuccess.jsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/panel/components/AccountSuccess.jsx b/app/panel/components/AccountSuccess.jsx index 2c6925868..fc18873a0 100644 --- a/app/panel/components/AccountSuccess.jsx +++ b/app/panel/components/AccountSuccess.jsx @@ -13,13 +13,14 @@ import React from 'react'; import { NavLink } from 'react-router-dom'; +import PropTypes from 'prop-types'; /** * @class Implement Account Success component which opens * in place of Sign In view on successful signing. * @memberof PanelClasses */ -const AccountSuccess = ({ email }) => ( +const AccountSuccess = ({ email, is_expert }) => (
@@ -31,7 +32,7 @@ const AccountSuccess = ({ email }) => ( {t('learn_more')} - + {t('subscribe_pitch_no_thanks')}
@@ -41,6 +42,7 @@ const AccountSuccess = ({ email }) => ( AccountSuccess.defaultProps = { email: '', + is_expert: PropTypes.bool.isRequired, }; export default AccountSuccess; From 9092328754cf1b73be3433b1f78dee12f8f99d40 Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 13 Jul 2020 14:51:17 -0400 Subject: [PATCH 2/4] Update propTypes --- app/panel/components/AccountSuccess.jsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/panel/components/AccountSuccess.jsx b/app/panel/components/AccountSuccess.jsx index fc18873a0..56acf801a 100644 --- a/app/panel/components/AccountSuccess.jsx +++ b/app/panel/components/AccountSuccess.jsx @@ -40,9 +40,13 @@ const AccountSuccess = ({ email, is_expert }) => (
); +// PropTypes ensure we pass required props of the correct type +AppView.propTypes = { + is_expert: PropTypes.bool.isRequired, +}; + AccountSuccess.defaultProps = { email: '', - is_expert: PropTypes.bool.isRequired, }; export default AccountSuccess; From a9b4b1b978e145233c3681f26e6d03a8c6b32af8 Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 13 Jul 2020 14:52:18 -0400 Subject: [PATCH 3/4] Fix propTypes --- app/panel/components/AccountSuccess.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/panel/components/AccountSuccess.jsx b/app/panel/components/AccountSuccess.jsx index 56acf801a..44efc8d47 100644 --- a/app/panel/components/AccountSuccess.jsx +++ b/app/panel/components/AccountSuccess.jsx @@ -41,7 +41,7 @@ const AccountSuccess = ({ email, is_expert }) => ( ); // PropTypes ensure we pass required props of the correct type -AppView.propTypes = { +AccountSuccess.propTypes = { is_expert: PropTypes.bool.isRequired, }; From 39de602a59d2508dffd05716bd85510f690eaaa9 Mon Sep 17 00:00:00 2001 From: Ben Date: Mon, 13 Jul 2020 14:56:55 -0400 Subject: [PATCH 4/4] Add email propType --- app/panel/components/AccountSuccess.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/app/panel/components/AccountSuccess.jsx b/app/panel/components/AccountSuccess.jsx index 44efc8d47..d0a0244bb 100644 --- a/app/panel/components/AccountSuccess.jsx +++ b/app/panel/components/AccountSuccess.jsx @@ -43,6 +43,7 @@ const AccountSuccess = ({ email, is_expert }) => ( // PropTypes ensure we pass required props of the correct type AccountSuccess.propTypes = { is_expert: PropTypes.bool.isRequired, + email: PropTypes.string, }; AccountSuccess.defaultProps = {