From 241105187f6cbbabcd5429c5d7e897be953cacb2 Mon Sep 17 00:00:00 2001 From: leuryr Date: Fri, 12 Mar 2021 13:10:01 -0500 Subject: [PATCH 1/2] Add onboarding Step 0 ping --- app/dawn-hub/Views/OnboardingView/OnboardingConstants.js | 3 +++ .../Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/dawn-hub/Views/OnboardingView/OnboardingConstants.js b/app/dawn-hub/Views/OnboardingView/OnboardingConstants.js index 71eb1e4cb..fc2b2be67 100644 --- a/app/dawn-hub/Views/OnboardingView/OnboardingConstants.js +++ b/app/dawn-hub/Views/OnboardingView/OnboardingConstants.js @@ -22,6 +22,9 @@ export const SUCCESS = '5'; // Setup Step Constants +// Step 0 +export const SETUP_STARTED = '1'; + // Step 1 export const SIGN_IN_SUCCESSFUL = '1'; export const CREATE_ACCOUNT_SUCCESSFUL = '2'; diff --git a/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx b/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx index 1abfe815e..3262e266d 100644 --- a/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx +++ b/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx @@ -14,7 +14,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import { NavLink } from 'react-router-dom'; -import { WELCOME } from '../../OnboardingView/OnboardingConstants'; +import { WELCOME, SETUP_STARTED } from '../../OnboardingView/OnboardingConstants'; /** * A Functional React component for rendering the Browser Welcome View @@ -29,7 +29,7 @@ const WelcomeView = (props) => {
{t('ghostery_dawn_onboarding_welcome')}
{t('ghostery_dawn_onboarding_welcome_message')}
- setSetupStep({ setup_step: WELCOME, origin: WELCOME })}> + setSetupStep({ setup_step: WELCOME, dawn_setup_number: SETUP_STARTED, origin: WELCOME })}> {t('ghostery_dawn_onboarding_lets_do_this')} From 11086396ac7fd13b2178ec91967562bb6604f10b Mon Sep 17 00:00:00 2001 From: leuryr Date: Mon, 15 Mar 2021 11:10:13 -0400 Subject: [PATCH 2/2] Fix ping not sending from Welcome --- .../Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx b/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx index 3262e266d..897a2a95b 100644 --- a/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx +++ b/app/dawn-hub/Views/OnboardingViews/Step0_WelcomeView/WelcomeView.jsx @@ -14,7 +14,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import { NavLink } from 'react-router-dom'; -import { WELCOME, SETUP_STARTED } from '../../OnboardingView/OnboardingConstants'; +import { ONBOARDING, WELCOME, SETUP_STARTED } from '../../OnboardingView/OnboardingConstants'; /** * A Functional React component for rendering the Browser Welcome View @@ -29,7 +29,7 @@ const WelcomeView = (props) => {
{t('ghostery_dawn_onboarding_welcome')}
{t('ghostery_dawn_onboarding_welcome_message')}
- setSetupStep({ setup_step: WELCOME, dawn_setup_number: SETUP_STARTED, origin: WELCOME })}> + setSetupStep({ setup_step: WELCOME, dawn_setup_number: SETUP_STARTED, origin: ONBOARDING })}> {t('ghostery_dawn_onboarding_lets_do_this')}