diff --git a/layouts/joomla/toolbar/batch.php b/layouts/joomla/toolbar/batch.php index 431a2f490743d..1ccd2d9d819e9 100644 --- a/layouts/joomla/toolbar/batch.php +++ b/layouts/joomla/toolbar/batch.php @@ -13,9 +13,11 @@ $title = $displayData['title']; JText::script('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST'); -$message = "alert(Joomla.JText._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST'));"; +JText::script('ERROR'); +$message = "{'error': [Joomla.JText._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST')]}"; +$alert = "Joomla.renderMessages(" . $message . ")"; ?> - diff --git a/libraries/cms/toolbar/button/confirm.php b/libraries/cms/toolbar/button/confirm.php index 18cb5c2103a4f..bb99cb433d5b7 100644 --- a/libraries/cms/toolbar/button/confirm.php +++ b/libraries/cms/toolbar/button/confirm.php @@ -88,12 +88,15 @@ public function fetchId($type = 'Confirm', $msg = '', $name = '', $text = '', $t protected function _getCommand($msg, $name, $task, $list) { JText::script('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST'); + JText::script('ERROR'); $cmd = "if (confirm('" . $msg . "')) { Joomla.submitbutton('" . $task . "'); }"; if ($list) { - $alert = "alert(Joomla.JText._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST'));"; + + $message = "{'error': [Joomla.JText._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST')]}"; + $alert = "Joomla.renderMessages(" . $message . ")"; $cmd = "if (document.adminForm.boxchecked.value == 0) { " . $alert . " } else { " . $cmd . " }"; } diff --git a/libraries/cms/toolbar/button/standard.php b/libraries/cms/toolbar/button/standard.php index ca7640766880c..692e10f5cf62c 100644 --- a/libraries/cms/toolbar/button/standard.php +++ b/libraries/cms/toolbar/button/standard.php @@ -122,7 +122,7 @@ protected function _getCommand($name, $task, $list) if ($list) { - $messages = "{'warning': [Joomla.JText._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST')]}"; + $messages = "{'error': [Joomla.JText._('JLIB_HTML_PLEASE_MAKE_A_SELECTION_FROM_THE_LIST')]}"; $alert = "Joomla.renderMessages(" . $messages . ")"; $cmd = "if (document.adminForm.boxchecked.value == 0) { " . $alert . " } else { " . $cmd . " }"; } diff --git a/tests/unit/suites/libraries/cms/toolbar/JToolbarButtonTest.php b/tests/unit/suites/libraries/cms/toolbar/JToolbarButtonTest.php index e88d274a04bf2..112b030e31c4c 100644 --- a/tests/unit/suites/libraries/cms/toolbar/JToolbarButtonTest.php +++ b/tests/unit/suites/libraries/cms/toolbar/JToolbarButtonTest.php @@ -123,7 +123,7 @@ public function testRender() { $type = array('Standard', 'test'); - $expected = "\n\n"; + $expected = "\n\n"; $this->assertEquals( $expected, diff --git a/tests/unit/suites/libraries/cms/toolbar/button/JToolbarButtonConfirmTest.php b/tests/unit/suites/libraries/cms/toolbar/button/JToolbarButtonConfirmTest.php index 67fac82173e53..ff4b1e00c34b8 100644 --- a/tests/unit/suites/libraries/cms/toolbar/button/JToolbarButtonConfirmTest.php +++ b/tests/unit/suites/libraries/cms/toolbar/button/JToolbarButtonConfirmTest.php @@ -92,10 +92,11 @@ protected function tearDown() */ public function testFetchButton() { - $html = "\n"; + $this->assertEquals( $this->object->fetchButton('Confirm', 'Confirm action?', 'confirm-test', 'Confirm?', 'article.save'), $html