diff --git a/administrator/components/com_users/models/notes.php b/administrator/components/com_users/models/notes.php index c186b50a140b8..81761cf6ece77 100644 --- a/administrator/components/com_users/models/notes.php +++ b/administrator/components/com_users/models/notes.php @@ -107,7 +107,7 @@ protected function getListQuery() { $query->where('a.state = ' . (int) $published); } - elseif ($published === '') + elseif ($published != '*') { $query->where('(a.state IN (0, 1))'); } diff --git a/administrator/components/com_users/tables/note.php b/administrator/components/com_users/tables/note.php index 8823c55839cdc..4806c7defa11e 100644 --- a/administrator/components/com_users/tables/note.php +++ b/administrator/components/com_users/tables/note.php @@ -67,95 +67,4 @@ public function store($updateNulls = false) // Attempt to store the data. return parent::store($updateNulls); } - - /** - * Method to set the publishing state for a row or list of rows in the database - * table. The method respects checked out rows by other users and will attempt - * to check-in rows that it can after adjustments are made. - * - * @param mixed $pks An optional array of primary key values to update. If not set the instance property value is used. - * @param integer $state The publishing state. eg. [0 = unpublished, 1 = published] - * @param integer $userId The user id of the user performing the operation. - * - * @return boolean True on success. - * - * @since 2.5 - */ - public function publish($pks = null, $state = 1, $userId = 0) - { - $k = $this->_tbl_key; - - // Sanitize input. - $pks = ArrayHelper::toInteger($pks); - $userId = (int) $userId; - $state = (int) $state; - - // If there are no primary keys set check to see if the instance key is set. - if (empty($pks)) - { - if ($this->$k) - { - $pks = array($this->$k); - } - // Nothing to set publishing state on, return false. - else - { - $this->setError(JText::_('JLIB_DATABASE_ERROR_NO_ROWS_SELECTED')); - - return false; - } - } - - $query = $this->_db->getQuery(true) - ->update($this->_db->quoteName($this->_tbl)) - ->set($this->_db->quoteName('state') . ' = ' . (int) $state); - - // Build the WHERE clause for the primary keys. - $query->where($k . '=' . implode(' OR ' . $k . '=', $pks)); - - // Determine if there is checkin support for the table. - if (!property_exists($this, 'checked_out') || !property_exists($this, 'checked_out_time')) - { - $checkin = false; - } - else - { - $query->where('(checked_out = 0 OR checked_out = ' . (int) $userId . ')'); - $checkin = true; - } - - // Update the publishing state for rows with the given primary keys. - $this->_db->setQuery($query); - - try - { - $this->_db->execute(); - } - catch (RuntimeException $e) - { - $this->setError($this->_db->getMessage()); - - return false; - } - - // If checkin is supported and all rows were adjusted, check them in. - if ($checkin && (count($pks) == $this->_db->getAffectedRows())) - { - // Checkin the rows. - foreach ($pks as $pk) - { - $this->checkin($pk); - } - } - - // If the JTable instance value is in the list of primary keys that were set, set the instance. - if (in_array($this->$k, $pks)) - { - $this->state = $state; - } - - $this->setError(''); - - return true; - } }