diff --git a/.gitignore b/.gitignore index ff5424ddd83b2..4df83665e1220 100644 --- a/.gitignore +++ b/.gitignore @@ -22,8 +22,19 @@ # phpDocumentor Logs # phpdoc-* -# Patch Tester +# Patch Tester # administrator/components/com_patchtester/ administrator/templates/hathor/html/com_patchtester components/com_patchtester/ +# OSX # +._* +.Spotlight-V100 +.Trashes + +# Windows # +Thumbs.db +Desktop.ini + +# Never ignore # +!.gitignore diff --git a/.travis.yml b/.travis.yml index 28017ed6f766c..c5ebdb1f7bcc9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,6 +8,8 @@ php: before_script: - composer self-update + - pyrus install -f pear/PHP_CodeSniffer-1.5.4 + - phpenv rehash - mysql -e 'create database joomla_ut;' - mysql joomla_ut < tests/unit/suites/database/stubs/mysql.sql - psql -c 'create database joomla_ut;' -U postgres @@ -15,6 +17,7 @@ before_script: script: - phpunit --configuration travisci-phpunit.xml + - phpcs --report=full --extensions=php -p --standard=build/phpcs/Joomla . branches: except: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1035a7b35bf9e..614571c6dd05f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,14 +2,10 @@ Contributing to the Joomla! CMS =============== All contributions are welcome to be submitted for review for inclusion in the Joomla! CMS, but before they will be accepted, we ask that you follow these simple steps: -1) Open an item on the Joomlacode tracker in the appropriate area. -* CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103 -* CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549 +1) Open an issue on our [Issue Tracker](http://issues.joomla.org/) or here on GitHub. If you can provide a fix create a pull request instead, it will automatically create the issue for you. 2) Follow the [Joomla! Coding Standards](http://joomla.github.io/coding-standards)! -3) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item and the GitHub issue or pull request. - Please be patient as not all items will be tested immediately (remember, all bug testing for the Joomla! CMS is done by volunteers) and be receptive to feedback about your code. #### Branches diff --git a/administrator/components/com_admin/controller.php b/administrator/components/com_admin/controller.php index 76ac053769e4c..c8a4ea86bd5b2 100644 --- a/administrator/components/com_admin/controller.php +++ b/administrator/components/com_admin/controller.php @@ -12,9 +12,7 @@ /** * Admin Controller * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminController extends JControllerLegacy { diff --git a/administrator/components/com_admin/controllers/profile.php b/administrator/components/com_admin/controllers/profile.php index 984c459cfd7cd..4884ef27a86b6 100644 --- a/administrator/components/com_admin/controllers/profile.php +++ b/administrator/components/com_admin/controllers/profile.php @@ -12,9 +12,7 @@ /** * User profile controller class. * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminControllerProfile extends JControllerForm { diff --git a/administrator/components/com_admin/helpers/html/directory.php b/administrator/components/com_admin/helpers/html/directory.php index 9ea9a8b45887a..5346819242767 100644 --- a/administrator/components/com_admin/helpers/html/directory.php +++ b/administrator/components/com_admin/helpers/html/directory.php @@ -12,9 +12,7 @@ /** * Utility class working with directory * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ abstract class JHtmlDirectory { diff --git a/administrator/components/com_admin/helpers/html/phpsetting.php b/administrator/components/com_admin/helpers/html/phpsetting.php index 3577eeb11dd37..717ac6407d207 100644 --- a/administrator/components/com_admin/helpers/html/phpsetting.php +++ b/administrator/components/com_admin/helpers/html/phpsetting.php @@ -12,9 +12,7 @@ /** * Utility class working with phpsetting * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ abstract class JHtmlPhpSetting { diff --git a/administrator/components/com_admin/helpers/html/system.php b/administrator/components/com_admin/helpers/html/system.php index c4fa369fae817..2c5150e73fde0 100644 --- a/administrator/components/com_admin/helpers/html/system.php +++ b/administrator/components/com_admin/helpers/html/system.php @@ -12,9 +12,7 @@ /** * Utility class working with system * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ abstract class JHtmlSystem { diff --git a/administrator/components/com_admin/models/help.php b/administrator/components/com_admin/models/help.php index 9e6139c8a3fee..1898b1b148d34 100644 --- a/administrator/components/com_admin/models/help.php +++ b/administrator/components/com_admin/models/help.php @@ -12,9 +12,7 @@ /** * Admin Component Help Model * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminModelHelp extends JModelLegacy { diff --git a/administrator/components/com_admin/models/profile.php b/administrator/components/com_admin/models/profile.php index 8d1935caeda59..e404b22270e49 100644 --- a/administrator/components/com_admin/models/profile.php +++ b/administrator/components/com_admin/models/profile.php @@ -14,9 +14,7 @@ /** * User model. * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminModelProfile extends UsersModelUser { diff --git a/administrator/components/com_admin/models/sysinfo.php b/administrator/components/com_admin/models/sysinfo.php index 0936ec6faa01f..9956e0709ac9c 100644 --- a/administrator/components/com_admin/models/sysinfo.php +++ b/administrator/components/com_admin/models/sysinfo.php @@ -12,9 +12,7 @@ /** * Model for the display of system information. * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminModelSysInfo extends JModelLegacy { diff --git a/administrator/components/com_admin/script.php b/administrator/components/com_admin/script.php index fa8495e779a68..2a741e209e6bd 100644 --- a/administrator/components/com_admin/script.php +++ b/administrator/components/com_admin/script.php @@ -12,9 +12,7 @@ /** * Script file of Joomla CMS * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6.4 + * @since 1.6.4 */ class JoomlaInstallerScript { diff --git a/administrator/components/com_admin/sql/updates/mysql/3.3.6-2014-09-30.sql b/administrator/components/com_admin/sql/updates/mysql/3.3.6-2014-09-30.sql new file mode 100644 index 0000000000000..73b7c1ba0ed3f --- /dev/null +++ b/administrator/components/com_admin/sql/updates/mysql/3.3.6-2014-09-30.sql @@ -0,0 +1,5 @@ +INSERT INTO `#__update_sites` (`name`, `type`, `location`, `enabled`) VALUES +('Joomla! Update Component Update Site', 'extension', 'http://update.joomla.org/core/extensions/com_joomlaupdate.xml', 1); + +INSERT INTO `#__update_sites_extensions` (`update_site_id`, `extension_id`) VALUES +((SELECT `update_site_id` FROM `#__update_sites` WHERE `name` = 'Joomla! Update Component Update Site'), (SELECT `extension_id` FROM `#__extensions` WHERE `name` = 'com_joomlaupdate')); diff --git a/administrator/components/com_admin/sql/updates/postgresql/3.3.6-2014-09-30.sql b/administrator/components/com_admin/sql/updates/postgresql/3.3.6-2014-09-30.sql new file mode 100644 index 0000000000000..fae9c20d45522 --- /dev/null +++ b/administrator/components/com_admin/sql/updates/postgresql/3.3.6-2014-09-30.sql @@ -0,0 +1,5 @@ +INSERT INTO "#__update_sites" ("name", "type", "location", "enabled") VALUES +('Joomla! Update Component Update Site', 'extension', 'http://update.joomla.org/core/extensions/com_joomlaupdate.xml', 1); + +INSERT INTO "#__update_sites_extensions" ("update_site_id", "extension_id") VALUES +((SELECT "update_site_id" FROM "#__update_sites" WHERE "name" = 'Joomla! Update Component Update Site'), (SELECT "extension_id" FROM "#__extensions" WHERE "name" = 'com_joomlaupdate')); diff --git a/administrator/components/com_admin/sql/updates/sqlazure/3.3.6-2014-09-30.sql b/administrator/components/com_admin/sql/updates/sqlazure/3.3.6-2014-09-30.sql new file mode 100644 index 0000000000000..309ade5b7c50a --- /dev/null +++ b/administrator/components/com_admin/sql/updates/sqlazure/3.3.6-2014-09-30.sql @@ -0,0 +1,5 @@ +INSERT INTO [#__update_sites] ([name], [type], [location], [enabled]) +SELECT 'Joomla! Update Component Update Site', 'extension', 'http://update.joomla.org/core/extensions/com_joomlaupdate.xml', 1; + +INSERT INTO [#__update_sites_extensions] ([update_site_id], [extension_id]) +SELECT (SELECT [update_site_id] FROM [#__update_sites] WHERE [name] = 'Joomla! Update Component Update Site'), (SELECT [extension_id] FROM [#__extensions] WHERE [name] = 'com_joomlaupdate'); diff --git a/administrator/components/com_admin/views/help/view.html.php b/administrator/components/com_admin/views/help/view.html.php index 01d6290d9c585..7793937fb46ff 100644 --- a/administrator/components/com_admin/views/help/view.html.php +++ b/administrator/components/com_admin/views/help/view.html.php @@ -12,9 +12,7 @@ /** * HTML View class for the Admin component * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminViewHelp extends JViewLegacy { @@ -49,7 +47,11 @@ class AdminViewHelp extends JViewLegacy protected $start_here = null; /** - * Display the view + * Execute and display a template script. + * + * @param string $tpl The name of the template file to parse; automatically searches through the template paths. + * + * @return mixed A string if successful, otherwise a Error object. */ public function display($tpl = null) { @@ -66,6 +68,8 @@ public function display($tpl = null) /** * Setup the Toolbar * + * @return void + * * @since 1.6 */ protected function addToolbar() diff --git a/administrator/components/com_admin/views/profile/view.html.php b/administrator/components/com_admin/views/profile/view.html.php index ed8f3be531886..d2d2a11016f20 100644 --- a/administrator/components/com_admin/views/profile/view.html.php +++ b/administrator/components/com_admin/views/profile/view.html.php @@ -12,9 +12,7 @@ /** * View class to allow users edit their own profile. * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminViewProfile extends JViewLegacy { @@ -25,7 +23,11 @@ class AdminViewProfile extends JViewLegacy protected $state; /** - * Display the view + * Execute and display a template script. + * + * @param string $tpl The name of the template file to parse; automatically searches through the template paths. + * + * @return mixed A string if successful, otherwise a Error object. */ public function display($tpl = null) { @@ -37,6 +39,7 @@ public function display($tpl = null) if (count($errors = $this->get('Errors'))) { JError::raiseError(500, implode("\n", $errors)); + return false; } @@ -50,6 +53,8 @@ public function display($tpl = null) /** * Add the page title and toolbar. * + * @return void + * * @since 1.6 */ protected function addToolbar() diff --git a/administrator/components/com_admin/views/sysinfo/view.html.php b/administrator/components/com_admin/views/sysinfo/view.html.php index 331a6cf86318e..74eb722eedfc9 100644 --- a/administrator/components/com_admin/views/sysinfo/view.html.php +++ b/administrator/components/com_admin/views/sysinfo/view.html.php @@ -12,9 +12,7 @@ /** * Sysinfo View class for the Admin component * - * @package Joomla.Administrator - * @subpackage com_admin - * @since 1.6 + * @since 1.6 */ class AdminViewSysinfo extends JViewLegacy { @@ -44,7 +42,11 @@ class AdminViewSysinfo extends JViewLegacy protected $directory = null; /** - * Display the view + * Execute and display a template script. + * + * @param string $tpl The name of the template file to parse; automatically searches through the template paths. + * + * @return mixed A string if successful, otherwise a Error object. */ public function display($tpl = null) { @@ -89,6 +91,8 @@ protected function _setSubMenu() /** * Setup the Toolbar * + * @return void + * * @since 1.6 */ protected function addToolbar() diff --git a/administrator/components/com_banners/controller.php b/administrator/components/com_banners/controller.php index 0c8e9236ccbef..dc1997b28c92f 100644 --- a/administrator/components/com_banners/controller.php +++ b/administrator/components/com_banners/controller.php @@ -12,19 +12,18 @@ /** * Banners master display controller. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersController extends JControllerLegacy { /** * Method to display a view. * - * @param boolean If true, the view output will be cached - * @param array An array of safe url parameters and their variable types, for valid values see {@link JFilterInput::clean()}. + * @param boolean $cachable If true, the view output will be cached + * @param array $urlparams An array of safe url parameters and their variable types, for valid values see {@link JFilterInput::clean()}. * * @return JController This object to support chaining. + * * @since 1.5 */ public function display($cachable = false, $urlparams = false) @@ -39,7 +38,6 @@ public function display($cachable = false, $urlparams = false) // Check for edit form. if ($view == 'banner' && $layout == 'edit' && !$this->checkEditId('com_banners.edit.banner', $id)) { - // Somehow the person just went to the form - we don't allow that. $this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id)); $this->setMessage($this->getError(), 'error'); @@ -49,7 +47,6 @@ public function display($cachable = false, $urlparams = false) } elseif ($view == 'client' && $layout == 'edit' && !$this->checkEditId('com_banners.edit.client', $id)) { - // Somehow the person just went to the form - we don't allow that. $this->setError(JText::sprintf('JLIB_APPLICATION_ERROR_UNHELD_ID', $id)); $this->setMessage($this->getError(), 'error'); diff --git a/administrator/components/com_banners/controllers/banner.php b/administrator/components/com_banners/controllers/banner.php index 4b32be74abc33..033ca79e87f1e 100644 --- a/administrator/components/com_banners/controllers/banner.php +++ b/administrator/components/com_banners/controllers/banner.php @@ -12,9 +12,7 @@ /** * Banner controller class. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersControllerBanner extends JControllerForm { diff --git a/administrator/components/com_banners/controllers/banners.php b/administrator/components/com_banners/controllers/banners.php index bb147df43fd2b..e1232d59defb7 100644 --- a/administrator/components/com_banners/controllers/banners.php +++ b/administrator/components/com_banners/controllers/banners.php @@ -12,9 +12,7 @@ /** * Banners list controller class. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersControllerBanners extends JControllerAdmin { diff --git a/administrator/components/com_banners/controllers/client.php b/administrator/components/com_banners/controllers/client.php index 1554db24ceabf..6c397f3c15f44 100644 --- a/administrator/components/com_banners/controllers/client.php +++ b/administrator/components/com_banners/controllers/client.php @@ -12,9 +12,7 @@ /** * Client controller class. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersControllerClient extends JControllerForm { diff --git a/administrator/components/com_banners/controllers/clients.php b/administrator/components/com_banners/controllers/clients.php index cd53ddf570e19..b7ad9fbdefa8a 100644 --- a/administrator/components/com_banners/controllers/clients.php +++ b/administrator/components/com_banners/controllers/clients.php @@ -12,9 +12,7 @@ /** * Clients list controller class. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersControllerClients extends JControllerAdmin { diff --git a/administrator/components/com_banners/controllers/tracks.php b/administrator/components/com_banners/controllers/tracks.php index 0c2905bc8aa4d..d6bdfc5bf01aa 100644 --- a/administrator/components/com_banners/controllers/tracks.php +++ b/administrator/components/com_banners/controllers/tracks.php @@ -12,9 +12,7 @@ /** * Tracks list controller class. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersControllerTracks extends JControllerLegacy { diff --git a/administrator/components/com_banners/controllers/tracks.raw.php b/administrator/components/com_banners/controllers/tracks.raw.php index 6b9db7052efd4..b144c1161c1f0 100644 --- a/administrator/components/com_banners/controllers/tracks.raw.php +++ b/administrator/components/com_banners/controllers/tracks.raw.php @@ -12,9 +12,7 @@ /** * Tracks list controller class. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersControllerTracks extends JControllerLegacy { diff --git a/administrator/components/com_banners/helpers/banners.php b/administrator/components/com_banners/helpers/banners.php index f127522b81c34..41e2ad9a695f7 100644 --- a/administrator/components/com_banners/helpers/banners.php +++ b/administrator/components/com_banners/helpers/banners.php @@ -12,9 +12,7 @@ /** * Banners component helper. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 1.6 + * @since 1.6 */ class BannersHelper extends JHelperContent { diff --git a/administrator/components/com_banners/helpers/html/banner.php b/administrator/components/com_banners/helpers/html/banner.php index 30ee8a60bfd6c..1eda74bbe43e6 100644 --- a/administrator/components/com_banners/helpers/html/banner.php +++ b/administrator/components/com_banners/helpers/html/banner.php @@ -12,9 +12,7 @@ /** * Banner HTML class. * - * @package Joomla.Administrator - * @subpackage com_banners - * @since 2.5 + * @since 2.5 */ abstract class JHtmlBanner { @@ -31,7 +29,9 @@ public static function clients() // Create the batch selector to change the client on a selection list. $lines = array( - '