From c996ee6e2ad64da13772d18d36136880895aea44 Mon Sep 17 00:00:00 2001 From: Federico Ariza Date: Tue, 10 May 2016 22:02:33 -0400 Subject: [PATCH 1/2] key events handler return value to False to stop propagation --- lib/matplotlib/backends/backend_gtk.py | 4 ++-- lib/matplotlib/backends/backend_gtk3.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/matplotlib/backends/backend_gtk.py b/lib/matplotlib/backends/backend_gtk.py index f439af2564e..efc16ba60fc 100644 --- a/lib/matplotlib/backends/backend_gtk.py +++ b/lib/matplotlib/backends/backend_gtk.py @@ -300,14 +300,14 @@ def key_press_event(self, widget, event): key = self._get_key(event) if _debug: print("hit", key) FigureCanvasBase.key_press_event(self, key, guiEvent=event) - return False # finish event propagation? + return True # stoping event propagation def key_release_event(self, widget, event): if _debug: print('FigureCanvasGTK.%s' % fn_name()) key = self._get_key(event) if _debug: print("release", key) FigureCanvasBase.key_release_event(self, key, guiEvent=event) - return False # finish event propagation? + return True # stoping event propagation def motion_notify_event(self, widget, event): if _debug: print('FigureCanvasGTK.%s' % fn_name()) diff --git a/lib/matplotlib/backends/backend_gtk3.py b/lib/matplotlib/backends/backend_gtk3.py index 2c4099a50e0..f9d2ecdae5a 100644 --- a/lib/matplotlib/backends/backend_gtk3.py +++ b/lib/matplotlib/backends/backend_gtk3.py @@ -251,14 +251,14 @@ def key_press_event(self, widget, event): key = self._get_key(event) if _debug: print("hit", key) FigureCanvasBase.key_press_event(self, key, guiEvent=event) - return False # finish event propagation? + return True # stoping event propagation def key_release_event(self, widget, event): if _debug: print('FigureCanvasGTK3.%s' % fn_name()) key = self._get_key(event) if _debug: print("release", key) FigureCanvasBase.key_release_event(self, key, guiEvent=event) - return False # finish event propagation? + return True # stoping event propagation def motion_notify_event(self, widget, event): if _debug: print('FigureCanvasGTK3.%s' % fn_name()) From cc15c7c5cb1f66f18cd2fddc74e318f90510b44e Mon Sep 17 00:00:00 2001 From: Federico Ariza Date: Wed, 11 May 2016 20:55:11 -0400 Subject: [PATCH 2/2] comment correction --- lib/matplotlib/backends/backend_gtk.py | 4 ++-- lib/matplotlib/backends/backend_gtk3.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/matplotlib/backends/backend_gtk.py b/lib/matplotlib/backends/backend_gtk.py index efc16ba60fc..7ebca484d7b 100644 --- a/lib/matplotlib/backends/backend_gtk.py +++ b/lib/matplotlib/backends/backend_gtk.py @@ -300,14 +300,14 @@ def key_press_event(self, widget, event): key = self._get_key(event) if _debug: print("hit", key) FigureCanvasBase.key_press_event(self, key, guiEvent=event) - return True # stoping event propagation + return True # stop event propagation def key_release_event(self, widget, event): if _debug: print('FigureCanvasGTK.%s' % fn_name()) key = self._get_key(event) if _debug: print("release", key) FigureCanvasBase.key_release_event(self, key, guiEvent=event) - return True # stoping event propagation + return True # stop event propagation def motion_notify_event(self, widget, event): if _debug: print('FigureCanvasGTK.%s' % fn_name()) diff --git a/lib/matplotlib/backends/backend_gtk3.py b/lib/matplotlib/backends/backend_gtk3.py index f9d2ecdae5a..8872e65427b 100644 --- a/lib/matplotlib/backends/backend_gtk3.py +++ b/lib/matplotlib/backends/backend_gtk3.py @@ -251,14 +251,14 @@ def key_press_event(self, widget, event): key = self._get_key(event) if _debug: print("hit", key) FigureCanvasBase.key_press_event(self, key, guiEvent=event) - return True # stoping event propagation + return True # stop event propagation def key_release_event(self, widget, event): if _debug: print('FigureCanvasGTK3.%s' % fn_name()) key = self._get_key(event) if _debug: print("release", key) FigureCanvasBase.key_release_event(self, key, guiEvent=event) - return True # stoping event propagation + return True # stop event propagation def motion_notify_event(self, widget, event): if _debug: print('FigureCanvasGTK3.%s' % fn_name())