From f31d7c4426d9801727c8ac4c734ad6db32c11ac9 Mon Sep 17 00:00:00 2001 From: Nikita Kniazev Date: Fri, 15 Jul 2016 00:04:41 +0300 Subject: [PATCH 1/3] Missing `cleanup` decorator in `test_subplots.test_exceptions` --- lib/matplotlib/tests/test_subplots.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/matplotlib/tests/test_subplots.py b/lib/matplotlib/tests/test_subplots.py index 08a8c272775..762d83b5f49 100644 --- a/lib/matplotlib/tests/test_subplots.py +++ b/lib/matplotlib/tests/test_subplots.py @@ -102,7 +102,7 @@ def test_shared(): check_visible(axs, [False, False, True, True], [True, False, True, False]) - +@cleanup def test_exceptions(): # TODO should this test more options? assert_raises(ValueError, plt.subplots, 2, 2, sharex='blah') From f80fb741cb4e5378bcf641b57f848848cd512581 Mon Sep 17 00:00:00 2001 From: Nikita Kniazev Date: Fri, 15 Jul 2016 00:08:53 +0300 Subject: [PATCH 2/3] Remove duplicates in `test_subplots` --- lib/matplotlib/tests/test_subplots.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lib/matplotlib/tests/test_subplots.py b/lib/matplotlib/tests/test_subplots.py index 762d83b5f49..0f6ed8f81c0 100644 --- a/lib/matplotlib/tests/test_subplots.py +++ b/lib/matplotlib/tests/test_subplots.py @@ -129,16 +129,6 @@ def test_subplots_offsettext(): axes[1, 1].plot(y, x) -@cleanup -def test_subplots(): - # things to test - # - are axes actually shared? - # - are tickmarks correctly hidden? - test_shared() - # - are exceptions thrown correctly - test_exceptions() - - if __name__ == "__main__": import nose nose.runmodule(argv=['-s', '--with-doctest'], exit=False) From 245481d7c5e880b0ad88b36d9cedf956ad3b9b04 Mon Sep 17 00:00:00 2001 From: Nikita Kniazev Date: Fri, 15 Jul 2016 12:07:55 +0300 Subject: [PATCH 3/3] Fixed typo in `test_subplots.test_exceptions` --- lib/matplotlib/tests/test_subplots.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/matplotlib/tests/test_subplots.py b/lib/matplotlib/tests/test_subplots.py index 0f6ed8f81c0..53aa0b0fed4 100644 --- a/lib/matplotlib/tests/test_subplots.py +++ b/lib/matplotlib/tests/test_subplots.py @@ -108,7 +108,7 @@ def test_exceptions(): assert_raises(ValueError, plt.subplots, 2, 2, sharex='blah') assert_raises(ValueError, plt.subplots, 2, 2, sharey='blah') # We filter warnings in this test which are genuine since - # the pount of this test is to ensure that this raises. + # the point of this test is to ensure that this raises. with warnings.catch_warnings(): warnings.filterwarnings('ignore', message='.*sharex\ argument\ to\ subplots',