From 7adbdaf5eca56856225c22d0ea457f2139bdaacf Mon Sep 17 00:00:00 2001 From: Gergely Ujvari Date: Mon, 15 Dec 2014 11:59:24 +0100 Subject: [PATCH] Put shortlinks into the metadata No longer ignoring rel=shortlink links. Many sides uses shortlinks, this'll help discovering identical pages --- src/plugin/document.js | 1 + test/spec/plugin/document_spec.js | 17 ++++++++++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/src/plugin/document.js b/src/plugin/document.js index 5eff7b45..3feb511f 100644 --- a/src/plugin/document.js +++ b/src/plugin/document.js @@ -127,6 +127,7 @@ function getLinks() { if (!(rel === "alternate" || rel === "canonical" || + rel === "shortlink" || rel === "bookmark")) { return; } diff --git a/test/spec/plugin/document_spec.js b/test/spec/plugin/document_spec.js index 7160fb8d..08d6b0dc 100644 --- a/test/spec/plugin/document_spec.js +++ b/test/spec/plugin/document_spec.js @@ -12,7 +12,8 @@ var FIXTURE_METADATA = { '', '', '', - '' + '', + '' ], highwire: [ '', @@ -66,7 +67,7 @@ describe('Document plugin', function () { it('should have links with absolute hrefs and types', function () { assert.ok(metadata.link); - assert.equal(metadata.link.length, 8); + assert.equal(metadata.link.length, 9); assert.equal(metadata.link[0].href, window.location.href); assert.equal(metadata.link[1].rel, "alternate"); assert.match(metadata.link[1].href, /^.+foo\.pdf$/); @@ -78,14 +79,16 @@ describe('Document plugin', function () { assert.equal(metadata.link[3].href, "http://example.com/bookmark"); assert.equal(metadata.link[4].rel, "canonical"); assert.equal(metadata.link[4].href, "http://example.com/bookmark/canonical.html"); - assert.equal(metadata.link[5].href, "doi:10.1175/JCLI-D-11-00015.1"); - assert.match(metadata.link[6].href, /.+foo\.pdf$/); - assert.equal(metadata.link[6].type, "application/pdf"); - assert.equal(metadata.link[7].href, "doi:10.1175/JCLI-D-11-00015.1"); + assert.equal(metadata.link[5].rel, "shortlink"); + assert.equal(metadata.link[5].href, "http://example.com/bookmark/short"); + assert.equal(metadata.link[6].href, "doi:10.1175/JCLI-D-11-00015.1"); + assert.match(metadata.link[7].href, /.+foo\.pdf$/); + assert.equal(metadata.link[7].type, "application/pdf"); + assert.equal(metadata.link[8].href, "doi:10.1175/JCLI-D-11-00015.1"); }); it('should ignore atom and RSS feeds and alternate languages', function () { - assert.equal(metadata.link.length, 8); + assert.equal(metadata.link.length, 9); }); it('should have highwire metadata', function () {