diff --git a/test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethods.java b/test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethods.java index 5db346a633e4..44660ecbcf7b 100644 --- a/test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethods.java +++ b/test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethods.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015, 2016, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -27,8 +27,7 @@ * @modules java.base/jdk.internal.misc * java.management * @library /test/lib - * @compile TestLogTouchedMethods.java PrintTouchedMethods.java - * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+LogTouchedMethods PrintTouchedMethods + * @run driver PrintTouchedMethods */ import java.io.File; @@ -44,7 +43,7 @@ public static void main(String args[]) throws Exception { "-XX:-UnlockDiagnosticVMOptions", "-XX:+LogTouchedMethods", "-XX:+PrintTouchedMethodsAtExit", - "TestLogTouchedMethods"); + TestLogTouchedMethods.class.getName()); // UnlockDiagnostic turned off, should fail OutputAnalyzer output = new OutputAnalyzer(pb.start()); @@ -55,7 +54,7 @@ public static void main(String args[]) throws Exception { "-XX:+UnlockDiagnosticVMOptions", "-XX:+LogTouchedMethods", "-XX:+PrintTouchedMethodsAtExit", - "TestLogTouchedMethods"); + TestLogTouchedMethods.class.getName()); output = new OutputAnalyzer(pb.start()); // check order: // 1 "# Method::print_touched_methods version 1" is the first in first line @@ -82,7 +81,7 @@ public static void main(String args[]) throws Exception { "-Xint", "-XX:+LogTouchedMethods", "-XX:+PrintTouchedMethodsAtExit", - "TestLogTouchedMethods"); + TestLogTouchedMethods.class.getName()); output = new OutputAnalyzer(pb.start()); lines = output.asLines(); @@ -105,7 +104,7 @@ public static void main(String args[]) throws Exception { "-XX:+LogTouchedMethods", "-XX:+PrintTouchedMethodsAtExit", "-XX:-TieredCompilation", - "TestLogTouchedMethods"); + TestLogTouchedMethods.class.getName()); output = new OutputAnalyzer(pb.start()); lines = output.asLines(); @@ -121,16 +120,5 @@ public static void main(String args[]) throws Exception { output.shouldContain("TestLogTouchedMethods.methodA:()V"); output.shouldNotContain("TestLogTouchedMethods.methodB:()V"); output.shouldHaveExitValue(0); - - // Test jcmd PrintTouchedMethods VM.print_touched_methods - String pid = Long.toString(ProcessTools.getProcessId()); - pb = new ProcessBuilder(); - pb.command(new String[] {JDKToolFinder.getJDKTool("jcmd"), pid, "VM.print_touched_methods"}); - output = new OutputAnalyzer(pb.start()); - try { - output.shouldContain("PrintTouchedMethods.main:([Ljava/lang/String;)V"); - } catch (RuntimeException e) { - output.shouldContain("Unknown diagnostic command"); - } - } + } } diff --git a/test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethodsJcmd.java b/test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethodsJcmd.java new file mode 100644 index 000000000000..f3188007941f --- /dev/null +++ b/test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethodsJcmd.java @@ -0,0 +1,50 @@ +/* + * Copyright (c) 2015, 2021, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8025692 + * @summary Test jcmd PrintTouchedMethods VM.print_touched_methods + * @modules java.base/jdk.internal.misc + * java.management + * @library /test/lib + * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+LogTouchedMethods PrintTouchedMethodsJcmd + */ + +import jdk.test.lib.process.OutputAnalyzer; +import jdk.test.lib.JDKToolFinder; + +public class PrintTouchedMethodsJcmd { + + public static void main(String args[]) throws Exception { + var pid = Long.toString(ProcessHandle.current().pid()); + var pb = new ProcessBuilder(); + pb.command(new String[] {JDKToolFinder.getJDKTool("jcmd"), pid, "VM.print_touched_methods"}); + var output = new OutputAnalyzer(pb.start()); + try { + output.shouldContain("PrintTouchedMethodsJcmd.main:([Ljava/lang/String;)V"); + } catch (RuntimeException e) { + output.shouldContain("Unknown diagnostic command"); + } + } +}