diff --git a/scripts/gen-favicon.mjs b/scripts/gen-favicon.mjs
new file mode 100644
index 0000000000..3c250b1a20
--- /dev/null
+++ b/scripts/gen-favicon.mjs
@@ -0,0 +1,138 @@
+#!/usr/bin/env node
+// #4830: deterministic favicon generator. Draws the panel brand mark (∞ on an
+// accent-blue rounded square, 4x4 supersampled), encodes 16px + 32px PNGs into
+// one .ico container, and writes src/web/favicon.ts — the base64 const served
+// at GET /favicon.ico (admin.ts) and declared by the panel head (page.ts).
+// Re-run after changing the drawing below; output is deterministic (no
+// timestamps, zlib level fixed). Node builtins only — no dependencies.
+import { deflateSync } from "node:zlib";
+import { writeFileSync } from "node:fs";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+
+const ACCENT = [0x21, 0x85, 0xd0]; // styles.ts --accent (light theme, #2185d0)
+const GLYPH = [0xff, 0xff, 0xff];
+const RING_R = 0.155; // loop radius, unit space
+const RING_HW = 0.052; // ring half-stroke width
+const RING_CX = [0.36, 0.64]; // loop centers (y is 0.5)
+const CORNER_R = 0.17; // badge corner radius
+const SS = 4; // supersamples per side
+
+function roundedRectInside(u, v) {
+ const qx = Math.abs(u - 0.5) - (0.5 - CORNER_R);
+ const qy = Math.abs(v - 0.5) - (0.5 - CORNER_R);
+ const ox = Math.max(qx, 0);
+ const oy = Math.max(qy, 0);
+ return Math.hypot(ox, oy) + Math.min(Math.max(qx, qy), 0) - CORNER_R <= 0;
+}
+
+function sampleColor(u, v) {
+ if (!roundedRectInside(u, v)) return [0, 0, 0, 0];
+ let onGlyph = false;
+ for (const cx of RING_CX) {
+ if (Math.abs(Math.hypot(u - cx, v - 0.5) - RING_R) <= RING_HW) { onGlyph = true; break; }
+ }
+ const c = onGlyph ? GLYPH : ACCENT;
+ return [c[0], c[1], c[2], 255];
+}
+
+function render(size) {
+ const px = Buffer.alloc(size * size * 4);
+ const step = 1 / size;
+ for (let y = 0; y < size; y++) {
+ for (let x = 0; x < size; x++) {
+ let r = 0, g = 0, b = 0, a = 0;
+ for (let sy = 0; sy < SS; sy++) {
+ for (let sx = 0; sx < SS; sx++) {
+ const u = (x + (sx + 0.5) / SS) * step;
+ const v = (y + (sy + 0.5) / SS) * step;
+ const s = sampleColor(u, v);
+ r += s[0]; g += s[1]; b += s[2]; a += s[3];
+ }
+ }
+ const n = SS * SS;
+ const i = (y * size + x) * 4;
+ px[i] = Math.round(r / n);
+ px[i + 1] = Math.round(g / n);
+ px[i + 2] = Math.round(b / n);
+ px[i + 3] = Math.round(a / n);
+ }
+ }
+ return px;
+}
+
+const CRC_TABLE = new Uint32Array(256).map((_, n) => {
+ let c = n;
+ for (let k = 0; k < 8; k++) c = c & 1 ? 0xedb88320 ^ (c >>> 1) : c >>> 1;
+ return c >>> 0;
+});
+
+function crc32(buf) {
+ let c = 0xffffffff;
+ for (let i = 0; i < buf.length; i++) c = CRC_TABLE[(c ^ buf[i]) & 0xff] ^ (c >>> 8);
+ return (c ^ 0xffffffff) >>> 0;
+}
+
+const PNG_SIG = Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a]);
+
+function pngChunk(type, data) {
+ const len = Buffer.alloc(4);
+ len.writeUInt32BE(data.length, 0);
+ const body = Buffer.concat([Buffer.from(type, "ascii"), data]);
+ const crc = Buffer.alloc(4);
+ crc.writeUInt32BE(crc32(body), 0);
+ return Buffer.concat([len, body, crc]);
+}
+
+function encodePng(size, rgba) {
+ const ihdr = Buffer.alloc(13);
+ ihdr.writeUInt32BE(size, 0);
+ ihdr.writeUInt32BE(size, 4);
+ ihdr[8] = 8; // bit depth
+ ihdr[9] = 6; // color type RGBA
+ const rowBytes = size * 4;
+ const raw = Buffer.alloc(size * (rowBytes + 1));
+ for (let y = 0; y < size; y++) {
+ raw[y * (rowBytes + 1)] = 0; // filter type none
+ rgba.copy(raw, y * (rowBytes + 1) + 1, y * rowBytes, (y + 1) * rowBytes);
+ }
+ return Buffer.concat([PNG_SIG, pngChunk("IHDR", ihdr), pngChunk("IDAT", deflateSync(raw, { level: 9 })), pngChunk("IEND", Buffer.alloc(0))]);
+}
+
+function encodeIco(entries) {
+ const header = Buffer.alloc(6);
+ header.writeUInt16LE(0, 0); // reserved
+ header.writeUInt16LE(1, 2); // type: icon
+ header.writeUInt16LE(entries.length, 4);
+ const dataStart = 6 + entries.length * 16;
+ let offset = dataStart;
+ const dirs = [];
+ const payloads = [];
+ for (const e of entries) {
+ const d = Buffer.alloc(16);
+ d[0] = e.size >= 256 ? 0 : e.size;
+ d[1] = e.size >= 256 ? 0 : e.size;
+ d.writeUInt16LE(1, 4); // planes
+ d.writeUInt16LE(32, 6); // bit count
+ d.writeUInt32LE(e.png.length, 8);
+ d.writeUInt32LE(offset, 12);
+ offset += e.png.length;
+ dirs.push(d);
+ payloads.push(e.png);
+ }
+ return Buffer.concat([header, ...dirs, ...payloads]);
+}
+
+const sizes = [16, 32];
+const entries = sizes.map((size) => ({ size, png: encodePng(size, render(size)) }));
+const ico = encodeIco(entries);
+const base64 = ico.toString("base64");
+
+const out = path.join(path.dirname(fileURLToPath(import.meta.url)), "..", "src", "web", "favicon.ts");
+writeFileSync(out, `// #4830: generated by scripts/gen-favicon.mjs — re-run that script after
+// changing its drawing code, do not edit this constant by hand. Served at
+// GET /favicon.ico (src/server/admin.ts) and declared by the panel head
+// (src/web/page.ts).
+export const FAVICON_ICO_BASE64 = "${base64}";
+`);
+console.log(`wrote ${out}: ico=${ico.length}B base64=${base64.length} chars (${entries.map((e) => `${e.size}px/${e.png.length}B`).join(", ")})`);
diff --git a/src/server/admin.ts b/src/server/admin.ts
index bd0fb963e9..3e64cf0a53 100644
--- a/src/server/admin.ts
+++ b/src/server/admin.ts
@@ -37,6 +37,7 @@ import { handleBlogAssetGet, handleBlogGet } from "../web/blogfeed.js";
import { buildSessionReportMd, buildSessionReportSvg } from "../web/report.js";
import { queryLogLines } from "../web/logs-query.js";
import { buildDiagnostics } from "../web/diagnostics.js";
+import { FAVICON_ICO_BASE64 } from "../web/favicon.js";
import { ackSplitBrainContest, storageStatusWire } from "../storage/runtime-status.js";
import { snapshotShadowStatusWire } from "../server/snapshot-render.js";
import { attributionStatusWire } from "./attribution-status.js";
@@ -258,17 +259,17 @@ export async function handleAdminRoute(req: http.IncomingMessage, res: http.Serv
res.end(JSON.stringify({ ok: true, upstream: opts.upstream }));
return;
}
- // #3536: browsers probing the proxy origin for a favicon (the dsh desktop
- // settings panel frames /__bili/ and the frame fires GET /favicon.ico at
- // the ORIGIN ROOT) must be answered locally with 204 — falling through to
- // the relay would rewrite the host onto the configured upstream, burning a
- // request there and logging a 403 for a static asset no model client ever
- // asks for. The panel page itself also declares an empty icon (page.ts) so
- // well-behaved browsers never send the probe at all; this is the backstop
- // for browsers/timings that still do (probe before redirect, direct visits).
+ // #3536/#4830: browsers probing the proxy origin for a favicon (the dsh
+ // desktop settings panel frames /__bili/ and the frame fires GET
+ // /favicon.ico at the ORIGIN ROOT) must be answered locally — falling
+ // through to the relay rewrites the host onto the configured upstream,
+ // burning a request there and logging timeouts for a static asset no model
+ // client ever asks for. The panel page declares the bundled icon (page.ts)
+ // so well-behaved browsers fetch it once and cache it; this route is what
+ // serves those bytes (plus the backstop for probes that skip the page).
if (req.method === "GET" && req.url?.split("?", 2)[0] === "/favicon.ico") {
- res.writeHead(204);
- res.end();
+ res.writeHead(200, { "content-type": "image/x-icon", "cache-control": "no-cache" });
+ res.end(Buffer.from(FAVICON_ICO_BASE64, "base64"));
return;
}
if (req.method === "GET" && req.url === "/__bili/health") {
diff --git a/src/web/favicon.ts b/src/web/favicon.ts
new file mode 100644
index 0000000000..17f35d0189
--- /dev/null
+++ b/src/web/favicon.ts
@@ -0,0 +1,5 @@
+// #4830: generated by scripts/gen-favicon.mjs — re-run that script after
+// changing its drawing code, do not edit this constant by hand. Served at
+// GET /favicon.ico (src/server/admin.ts) and declared by the panel head
+// (src/web/page.ts).
+export const FAVICON_ICO_BASE64 = "AAABAAIAEBAAAAEAIAC8AAAAJgAAACAgAAABACAAOwEAAOIAAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAACDSURBVHjaY2Di4BUQj+5fr9h64T8pGKQHpJeBHM3IhjCQqxmGqW+Afu/l/5FL7vz3nnMTLgZig8RAcngNKNn86D8yuPriGxgjA5AarAaAbIFpAimad+oVXBOIDRKDGYbsOrgBEw69wJCEAXRLQGqpbwDFXqA4EKkSjQOTEinOTJRmZwAbuKrrLI8EOwAAAABJRU5ErkJggolQTkcNChoKAAAADUlIRFIAAAAgAAAAIAgGAAAAc3p69AAAAQJJREFUeNpjYIACFkEpBdHgpvnytYffK7Ze+E8LDDIbZAfILgZkwGPkl0BLi7E5BGQn3Of0tBzZEeCQAAUJvS2HYZDdDAPhe+RQYBgoy2F41AFDwwFpq+//n3DoBRyD+OSoIdkBkUvu/H/84ed/bAAkDrIEhPGpAZlBlgNKNj/6Ty0AMoskB9hOufb/4/c/GL458fAzTt/iUwMyC2Qm0Q5Yc/EtigFNu54SDB10X4L0IAOQmUQ7ANn3uDQiqwGxCXkElxqsDkAG2BIRKDjRAbYgBulFBkPHAQMeBQOeCAc8Gw54QTQoiuJBURmNtgdGhgMGvFk+4B2TAe+aDXjndKC75wCG5a0fNzrnNwAAAABJRU5ErkJggg==";
diff --git a/src/web/page.ts b/src/web/page.ts
index 35e6d7bf8a..0f1443275d 100644
--- a/src/web/page.ts
+++ b/src/web/page.ts
@@ -18,11 +18,12 @@ export function renderPage(origin: string, version: string, embed = false, theme
const caPath = rootCaPath();
const caPathEsc = escapeHtml(caPath);
const caReady = existsSync(caPath);
- // #3536: declare an EMPTY icon so browsers (dsh desktop's Electron frame
- // included) never fall back to probing /favicon.ico on the proxy origin —
- // that request used to miss every admin route and get relayed onto the
- // configured upstream (a wasted request + 403 noise in the log).
- return `
billion-context
+ // #3536/#4830: declare the bundled icon explicitly so browsers (dsh
+ // desktop's Electron frame included) fetch it from /favicon.ico — served
+ // locally by admin.ts — instead of falling back to a bare origin probe
+ // that used to miss every admin route and get relayed onto the configured
+ // upstream (a wasted request + timeout noise in the log).
+ return `billion-context