Checks before merge the automated
- Back to the Inbox
@@ -1072,7 +1088,7 @@
${linkify(q.question)}
}
// The trusted preview: the standard shape (data rows with proposals, result rows) as a table of
// what changes, changed rows first; anything else as a JSON tree.
-function resultPreview(result, data) {
+function resultPreview(result, data, fold = false) {
const META = ['v', 'question', 'review_sha256', 'data_sha256', 'answered_at', 'channel', 'summary'];
const rest = Object.fromEntries(Object.entries(result).filter(([k]) => !META.includes(k) && k !== 'rows'));
if (!(Array.isArray(data?.rows) && Array.isArray(result.rows))) return `
` : ''}`;
+ // folded (the review panel's answer bar): the counts are the summary and the rows open on demand
+ return `${fold ? `${counts} · ${RV?.rowsOpen ? 'hide' : 'show'} every row${table}` : `
${counts}
${table}`}
${strange.length ? `
${strange.length} row${strange.length === 1 ? '' : 's'} in the result ${strange.length === 1 ? 'is' : 'are'} not in the data: ${strange.slice(0, 5).map((r) => `${esc(isPlainObj(r) ? r.id : JSON.stringify(r))}`).join(', ')}
RV.frame = f;
const label = document.createElement('div');
label.className = 'rv-frame-label';
- label.innerHTML = 'The agent’s page. It runs sandboxed, with no network and no access to this dashboard; it can only propose an answer, which shows in the panel below.';
+ label.innerHTML = 'The agent’s page: sandboxed, no network, no access to this dashboard. It can only propose; check the bar below before you answer.';
$('rv-frame-wrap').replaceChildren(label, f);
}
+const RV_CLOSE = '';
function renderReviewHead(note = '') {
const info = RV.info;
+ const CLOSE = RV_CLOSE;
if (RV.preview) {
- $('rv-head').innerHTML = `
PREVIEW, not asked
-
${esc(info.path || 'No page given')}
-
${esc(info.path)}${info.ref ? ` at ${esc(info.ref)}` : ' on main'}${info.dataPath ? ` · data ${esc(info.dataPath)}${info.data ? '' : ' (not loaded)'}` : ' · no data (add &data=<path>)'}
-
This is how the owner will see the page. Nothing here is a question yet, so nothing can be answered or saved.
- ${note ? `
${esc(note)}
` : ''}${info.path ? '' : '
Open it as #review-preview?path=<repo path>&ref=<branch>&data=<repo path>.
'}
`;
+ $('rv-head').innerHTML = `
PREVIEW, not asked
${esc(info.path || 'No page given')}
+
${esc(info.path)}${info.ref ? ` at ${esc(info.ref)}` : ' on main'}${info.dataPath ? ` · data ${esc(info.dataPath)}${info.data ? '' : ' (not loaded)'}` : ' · no data (add &data=<path>)'}
+ This is how the owner will see the page. Nothing here is a question yet, so nothing can be answered or saved.
+ ${note ? `
${esc(note)}
` : ''}${info.path ? '' : '
Open it as #review-preview?path=<repo path>&ref=<branch>&data=<repo path>.
Check the answer panel, not the page, before you answer. The page is the agent’s; the panel is the dashboard’s, and shows exactly what will be recorded.
' : '') : '
The page or data changed since the supervisor asked. Nothing can be answered here. Tell the supervisor to ask again.
'}
-
`;
+ // one line for the question, one for the facts; the rest folds away so the agent's page gets the height
+ const more = [rv.title && rv.title !== info.question ? `
${(info.blocks || []).length ? `holds up ${info.blocks.map(tlink).join(', ')}` : info.ticket ? `about ${tlink(info.ticket)}` : ''}${rv.data ? `${esc(rv.data.rows)} rows` : ''}${ok ? 'verified' : `${esc(info.result_status)}`}
+ The question in full
${more}
+ ${ok ? '' : '
The page or data changed since the supervisor asked. Nothing can be answered here. Tell the supervisor to ask again.
'}`;
showProgress();
}
function showProgress() {
const el = $('rv-progress');
const p = RV?.progress;
- if (el) el.innerHTML = p && p.total ? `· ${esc(p.done)} of ${esc(p.total)} decided` : '';
+ if (el) el.innerHTML = p && p.total ? `${esc(p.done)} of ${esc(p.total)} decided` : '';
}
// The panel's right side, drawn once per view: autosave status, Answer, Send it back.
function renderReviewActions() {
@@ -1283,12 +1306,12 @@
What you’re answering drawn by the dashboard from the page’s proposal, not by the page
- ${p ? resultPreview(p.obj, info.data) + raw(p.text, p.bytes, p.sha256, RV.preview ? 'What the page proposes (in a real question, what the agent would receive)' : 'This is exactly what the agent will receive') : '
Nothing proposed yet. Work through the page above; its answer shows here.
'}
+ el.innerHTML = `
What you’re answering drawn by the dashboard, not the page
+ ${p ? resultPreview(p.obj, info.data, true) + raw(p.text, p.bytes, p.sha256, RV.preview ? 'What the page proposes (in a real question, what the agent would receive)' : 'This is exactly what the agent will receive') : '
Nothing proposed yet. Work through the page above; its answer shows here.
'}
${RV.dropped ? `
${RV.dropped} message${RV.dropped === 1 ? '' : 's'} from the page ${RV.dropped === 1 ? 'was' : 'were'} refused.
return tellFrame({ type: 'markdown-result', id: m.id, html });
}
if (m.type === 'open') return openFromReview(m);
- if (m.type === 'resize') {
- const max = Math.max(320, innerHeight - 140);
- RV.frame.style.height = `${Math.round(Math.min(Math.max(m.height + 4, 320), max))}px`;
- }
+ // resize: the frame fills the panel's height, so a page's reported height needs no action
}
window.addEventListener('message', (ev) => {
if (!RV?.frame) return;
@@ -1916,9 +1936,11 @@
History
}
}
}
+let ROUTED = false;
function route() {
const raw = location.hash.slice(1);
- if (raw.startsWith('review/') || raw.startsWith('review-preview')) return void openReview(raw);
+ if (raw.startsWith('review/') || raw.startsWith('review-preview')) { if (!RV) RV_FROM = ROUTED ? raw : null; ROUTED = true; return void openReview(raw); }
+ ROUTED = true; RV_FROM = null;
// back from a review to a section: the section was hidden when the browser looked for it
// (and the Inbox cards redraw, so a card's progress pill is the one the review just reported)
if (closeReview()) { if (DATA) render(DATA); if (/^[a-z]+$/.test(raw)) document.getElementById(raw)?.scrollIntoView(); }
@@ -1935,8 +1957,12 @@
History
}
window.addEventListener('hashchange', () => { if (DATA) route(); });
$('drawer-close').addEventListener('click', closeDrawer);
-$('scrim').addEventListener('click', closeDrawer);
-document.addEventListener('keydown', (e) => { if (e.key === 'Escape' && !$('drawer').hidden) closeDrawer(); });
+$('scrim').addEventListener('click', () => (RV ? leaveReview() : closeDrawer()));
+document.addEventListener('keydown', (e) => { if (e.key !== 'Escape') return; if (RV) leaveReview(); else if (!$('drawer').hidden) closeDrawer(); });
+document.addEventListener('click', (e) => { if (e.target.closest('[data-rv-close]')) leaveReview(); });
+// a review opened from the dashboard closes back to it; one opened from a link goes to the Inbox
+let RV_FROM = null;
+function leaveReview() { if (RV_FROM !== null) history.back(); else location.hash = '#inbox'; }
// ---- loop tabs ----
let TAB = 'observe';
@@ -2228,6 +2254,11 @@
${linkify(k.statement)}
const id = dsend.dataset.decline;
return void reviewDecline(id, document.querySelector(`textarea[data-q="${CSS.escape(id)}"]`)?.value.trim() ?? '', id, dsend);
}
+ if (ev.target.closest('[data-rv-rows] > summary')) {
+ ev.preventDefault();
+ RV.rowsOpen = !RV.rowsOpen;
+ return void renderReviewPreview();
+ }
if (ev.target.closest('[data-rv-raw]')) {
const pre = ev.target.closest('p')?.nextElementSibling;
if (pre?.classList.contains('rv-raw')) { pre.hidden = !pre.hidden; ev.target.textContent = pre.hidden ? 'Show raw JSON' : 'Hide raw JSON'; if (RV) RV.rawOpen = !pre.hidden; }