From ffb6f5ad4610f0c6b5f793f9c2f0954f8754a06b Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Thu, 11 Oct 2018 15:08:59 -0700 Subject: [PATCH 1/2] remove unnecessary unsafe impls --- audio/src/decoder.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/audio/src/decoder.rs b/audio/src/decoder.rs index d38b95f3..8d99999c 100644 --- a/audio/src/decoder.rs +++ b/audio/src/decoder.rs @@ -51,9 +51,6 @@ impl AudioDecoderCallbacks { } } -unsafe impl Send for AudioDecoderCallbacks {} -unsafe impl Sync for AudioDecoderCallbacks {} - pub struct AudioDecoderCallbacksBuilder { eos: Option>, error: Option>, From 7adef96e57709b6e0930485e0ecbb945bcbac286 Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Fri, 12 Oct 2018 08:56:53 -0700 Subject: [PATCH 2/2] Use assert_eq --- audio/src/buffer_source_node.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/src/buffer_source_node.rs b/audio/src/buffer_source_node.rs index 73850bcc..7c4fde3b 100644 --- a/audio/src/buffer_source_node.rs +++ b/audio/src/buffer_source_node.rs @@ -198,7 +198,7 @@ impl AudioBuffer { pub fn from_buffers(buffers: Vec>) -> Self { for buf in &buffers { - assert!(buf.len() == buffers[0].len()) + assert_eq!(buf.len(), buffers[0].len()) } Self { buffers }