From 33663416378af6b019a9a33f6f84591789b0ba16 Mon Sep 17 00:00:00 2001
From: Ms2ger <Ms2ger@gmail.com>
Date: Mon, 19 Sep 2016 15:15:50 +0200
Subject: [PATCH] Return a ConversionResult::Failure when converting a
 non-iterable value to Vec.

---
 src/conversions.rs      | 6 +++++-
 tests/vec_conversion.rs | 9 +++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/conversions.rs b/src/conversions.rs
index 193b0be9b..95f2f14b4 100644
--- a/src/conversions.rs
+++ b/src/conversions.rs
@@ -585,10 +585,14 @@ impl<C: Clone, T: FromJSValConvertible<Config=C>> FromJSValConvertible for Vec<T
         let mut iterator = ForOfIteratorGuard::new(cx, &mut iterator);
         let iterator = &mut *iterator.root;
 
-        if !iterator.init(value, ForOfIterator_NonIterableBehavior::ThrowOnNonIterable) {
+        if !iterator.init(value, ForOfIterator_NonIterableBehavior::AllowNonIterable) {
             return Err(())
         }
 
+        if iterator.iterator.ptr.is_null() {
+            return Ok(ConversionResult::Failure("Value is not iterable".into()));
+        }
+
         let mut ret = vec![];
 
         loop {
diff --git a/tests/vec_conversion.rs b/tests/vec_conversion.rs
index 078dae2fa..95fdd2ae0 100644
--- a/tests/vec_conversion.rs
+++ b/tests/vec_conversion.rs
@@ -6,6 +6,7 @@
 extern crate js;
 
 use js::conversions::ConversionBehavior;
+use js::conversions::ConversionResult;
 use js::conversions::FromJSValConvertible;
 use js::conversions::ToJSValConvertible;
 use js::jsapi::CompartmentOptions;
@@ -57,5 +58,13 @@ fn vec_conversion() {
                                  ConversionBehavior::Default).unwrap();
 
         assert_eq!(&orig_vec, converted.get_success_value().unwrap());
+
+        rt.evaluate_script(global, "({})", "test", 1, rval.handle_mut()).unwrap();
+        let converted = Vec::<i32>::from_jsval(cx, rval.handle(),
+                                               ConversionBehavior::Default);
+        assert!(match converted {
+            Ok(ConversionResult::Failure(_)) => true,
+            _ => false,
+        });
     }
 }