From c109ae78b8d74632430af5fb924c0a4bba5cb55b Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Fri, 31 Jan 2020 09:16:25 +0100 Subject: [PATCH 1/2] Sign UWP packages by default. --- python/servo/package_commands.py | 12 ++++++++---- support/hololens/ServoApp/ServoApp.vcxproj | 2 +- .../ServoApp/ServoApp_TemporaryKey.pfx | Bin 2568 -> 2512 bytes support/hololens/package.msbuild | 4 ++-- 4 files changed, 11 insertions(+), 7 deletions(-) diff --git a/python/servo/package_commands.py b/python/servo/package_commands.py index a663763a3985..b4341f1af538 100644 --- a/python/servo/package_commands.py +++ b/python/servo/package_commands.py @@ -209,8 +209,11 @@ class PackageCommands(CommandBase): default=None, action='append', help='Create an APPX package') + @CommandArgument('--ms-app-store', + default=None, + action='store_true') def package(self, release=False, dev=False, android=None, magicleap=None, debug=False, - debugger=None, target=None, flavor=None, maven=False, uwp=None): + debugger=None, target=None, flavor=None, maven=False, uwp=None, ms_app_store=False): if android is None: android = self.config["build"]["android"] if target and android: @@ -234,7 +237,7 @@ def package(self, release=False, dev=False, android=None, magicleap=None, debug= target_dir = path.dirname(binary_path) if uwp: vs_info = self.vs_dirs() - build_uwp(uwp, dev, vs_info['msbuild']) + build_uwp(uwp, dev, vs_info['msbuild'], not ms_app_store) elif magicleap: if platform.system() not in ["Darwin"]: raise Exception("Magic Leap builds are only supported on macOS.") @@ -739,7 +742,7 @@ def call_git(cmd, **kwargs): return 0 -def build_uwp(platforms, dev, msbuild_dir): +def build_uwp(platforms, dev, msbuild_dir, sign_package): if any(map(lambda p: p not in ['x64', 'x86', 'arm64'], platforms)): raise Exception("Unsupported appx platforms: " + str(platforms)) if dev and len(platforms) > 1: @@ -764,7 +767,8 @@ def build_uwp(platforms, dev, msbuild_dir): ) build_file.close() # Generate an appxbundle. - subprocess.check_call([msbuild, "/m", build_file.name]) + sign_package_value = "true" if sign_package else "false" + subprocess.check_call([msbuild, "/m", build_file.name, "/p:AppxPackageSigningEnabled=" + sign_package_value]) os.unlink(build_file.name) print("Creating ZIP") diff --git a/support/hololens/ServoApp/ServoApp.vcxproj b/support/hololens/ServoApp/ServoApp.vcxproj index 86873e5dda82..4fa93f76ef6a 100644 --- a/support/hololens/ServoApp/ServoApp.vcxproj +++ b/support/hololens/ServoApp/ServoApp.vcxproj @@ -62,6 +62,7 @@ + ServoApp_TemporaryKey.pfx False False Always @@ -69,7 +70,6 @@ 1 OnApplicationRun False - 45A22CA001C9C6BE412BF449FBE70FEDE635831F diff --git a/support/hololens/ServoApp/ServoApp_TemporaryKey.pfx b/support/hololens/ServoApp/ServoApp_TemporaryKey.pfx index 8917164b3bb536b2359938057359e65f28e40f1f..a1224301b62b7df588f4d545addb5783f96b6dff 100644 GIT binary patch delta 2326 zcmV+x3F-ET6wnhQFoFrp0s#Xsf(eKQ2`Yw2hW8Bt2LYgh33&v933V`n32~7kMt}6~ z6;R~j7gGWP2haq91lSX@w%8tAmhdAh_4bG)f^g_j!8NT9nqCaX2Qd~UgveG@Av>90 zHXbtkn!)oC2NDfV=W3ewall%oW0)%xoezZrhy#yNA@T?KPcM> zLL&(zVA$AuH-P`;-(8AFu)BzCF@M43e_gyamE?XQ-%1G=>NAALVbq=X?Xh@TH(vf- z5@$iuwLE)(VJ4im(^bR@jK!lDNRdMQs+}ND?)XWj`KVKv7ZIXTmpW_S_#A9NhV07S zq=-p-_Ll)c=1pqQrzg)7%Erl)g$Jf*!yK}e3g3bEH?RT2+s*MOPAeV|6Z(CgWZ#YWeD!ByXxnL?w5_C700EiP$d%rV}8o-$I^D))_?jH80ZV~9=y6$Sq672;hu~*TP%GWZ2Sq=&Ho}@k-OrN z1=M4ok@Upw=P^c#FtBmV_gE6OtszE8qLjG1NUk_Ln&EcRY1c)I1Zi;k2&tN4)}&&gaA4}Z0>se!kSa^xlj-4D~2 zms*CKpw)k1QUM1LBz{|p^WtK7R5^0rO4Q_Tt7}+nTH>|~9D<+sy)v)~m1X}32zT~u zfOZLc97C?GxB-$O+mU_7I9zHPvMem+g4MNgnlV6Eh`BjgJgFMxovty6nH&Q?V*|d< z<-s=2D64=rM}Myx^`0`oYw5zKQ5e=`%TKA!06-=#W$O`HvDhV*3;cNA3y5ov-QG*Q zE@a>j90oJxV!!>o7kC$xZ=14cM7-wyD6-Y3;Bv}kDB@zR(P6T(1Ee#}d7VH!e~HX%sf6sA|dhCuems5E)XpOd-b530XPMd& zPx0RQQb|PT2KO9=fyXxZTdF^*j)KhDW7&Wjc9@?s(V}nP_jy(nmPQkLj_N|ok*ild zSC9+o7?;=_1h!J1WvBGTuaLb54@s~Sk;<>FPtpqC=yct7Fnzir!m%|yzp+dTXjMFT zr{za9PJa`P#_SLGyLxx%D__h}2s7bN%Pmt32(0a5ifc%MF=cK166kfvcQF>BQ6>1<1S~pTahRgmu49%7CNdxb{ zCk4o4(_pM4jvcUfHJ}hNfz2=z1_>&LNQUctguM;3b#(#)2hf0m z11PpYYAqCY0qSee>Jl2P^3qJ@e)5GD`Zsj1wHB0bbtQpS*(cG0mfl3_jIw(b9b@J zUIW{3(u&Gmw-g$&(>G=#nN#Zs+a&6%v$vR?FaJ`=@o|QAt6#d+iA-@a*jczER*TxB zw2K}~J8^I1s~0^X$`#!O#u52oC}Q>@G*P{#W=G>-&|XY%L!BQh)Eal?5U8>Q?v%by|4kFRHn|T3IL8 zBR0NgqUri;pS=EPfjI2%u!?NxRe z#edVvE`wLrMNovzN-#?yFXW4oxQgD^8!J=IoIH}bEk<#*pa*rZmJ?~&mYzM~|1ra1^=qEj)D&!thA)c>XM9et$DyEp z*88OMRs}y6+;W%|?@CSUP&3`%PF<|fV|zIbOiXHPMMOAu`s0q4YfTr@=f`J4-zGTG zOt}>FSo>l%@t08;Y#lnFGL07_5!q~KTBMAzFgq|GFb4(&D-Ht!8Uz&D wQNFq?fm}P0`qzXFr^Uc7z-d_o6w%AqyZ4|N;X8n0o6AN>vpq-yPyzx6&>av&2LJ#7 delta 2383 zcmV-V39$Ci6NnTdFoFsM0s#Xsf(gI|2`Yw2hW8Bt2LYgh39$r%39T@K38|4HMt`Fb zMa)I@ZwLYc2haq91lWmX>Z{)m&ld`{z``B6l<+nr%3pq5IYg#-X4ek3J7&S!=(aO%)6tvq?*INcnW zS1WYr)JOR>=)3#^L~la`)h$Cb9e+*4^*>6HMtn~N{X=oiTunwR%}#WmKnzSOA|Tna z)RL_NZzKWrj4VoEp|s?;2EbWFS|JHV)~Md`efJ^{b%uCn!p~xK$CksmtZnZ=6>wU; zO#At=m@@X?ab%w95YAY`c!?N!zhSqSqSP97YP$wR2d`1~^2O+5XI{r@oqt#8@lP>e ziBU(t+sAMzmOjoljXic}ekLQAWYQ8-Xp@~%FStWgX=)yy-^F&tvEVgx38jbs7tPx7WcIxo3DHxpqZB^aX%v3vN-vGyh(Co zJgx2t8LBvUbm#dla|?d_`xYS2&W4^}50H&uK`>KolCqYMj&y~DJ%4gQ2IaoPaEHa@ zOHfxL-M;r|LS3%LJxGlxxu(s|(GeW$k$nDh zY`kFG3dA6`MG_( zbZLDz6i?zNHRljze_o$0kB8t`y&`heiAY(*=5i~J4eN*X!SR18{fBNlh3td!`GzO2 z?HPPI8GlUOti>h;sLFPPTtdagAd+2Tu=C`w6HZdoa1J1?CVwDlr_9Hq$$VUM6^qM* zwD*3H0APOG?)d? zX?Jm?21+;9NAf@##yQ$$YB-eLG?$X1?3{XKtnJQr@?0|BFjn2F{uF$$WPNwt+WPM8N|TOfPYy+ z$(Jga^j~8>rFTC8dO#k-@FbFT27sf3t%Q-kO+xq>uB>u7M`P{{JsLJ&!)4K16{~ZW zCOYQ7uYbY3k~xu~-m29+fZfLY>omOA+fNx6m!7vn;wQ{6t5m*wvhjGdWr8CP7K}tA zmF%13L8y6|_lemU8NfZq)PvO57~v}my>^mOys4Ms2ty<^{+>%H5O3vU{axl~fDP3p zpMWbzwki!!DfIzaUZbutfz2=z1_>&LNQUc)tTeNN4oWA9F%Jl74@wwDZq|gT z>$#=>5DP>M;Nc3lkRZ$Gycc3FdyPQD^nXQVRIDm@QW7@E7GxCc1c9N# zn(W7wuv`qk9}UL&LA^*TfVZ6wfV}tAIfd>50XEG0Wb8~pm;rr$q-=3g`ID`?oY?t` z-LZD4oo|SVYXc9&N!hb2fBSKPPn-yRI6s?{*|5M|(qCe6<&Cw`fMi(&-QJ^rU?R2w zL4AP0!GErfs-k)hm)$HeZAu5QUjPR{fraVjl)Y2mqr%JFO$Y|U(adB z)bfBGzR^om4HcGa=o#2Zco&+Rxya-Xwv;z}DnEAL2&2ECn^u4XD4 zay5ZXVqln{7g}QLQMeolN6y%UY2@aQOZ|YNCuv+oL!^y)1Ca%6(OToD$@eXsjR{_Q z*2Az#;|7WuiOmnjbnti3^)F(Yw|B;w{C~JZ6?`32F&pfk6U2LyO9Vpmh}y@);cBX$ z1&~WRoa+x{siD;|UJk`>NSek1cgwK4=KzSK;{FyZrJPFd)dBGbP-bBGbsuWRx3@K44hK4YxXQHFgq|GFb4(&D>M!R z0vZGqTG(WK4bQm&L?Y)C;g>hfLZ!u51QaCU7AqUq_~0E6uR*c?6!&uW0Dl4k2hb)m BWg!3n diff --git a/support/hololens/package.msbuild b/support/hololens/package.msbuild index d673876c3500..8d25a8d3fd65 100644 --- a/support/hololens/package.msbuild +++ b/support/hololens/package.msbuild @@ -9,6 +9,6 @@ + Properties="Configuration=%(ConfigAndPlatform.Identity);Platform=%(ConfigAndPlatform.Platform);AppxBundle=Always;AppxBundlePlatforms=%%PACKAGE_PLATFORMS%%;UseSubFolderForOutputDirDuringMultiPlatformBuild=false"/> - \ No newline at end of file + From efaa4c39413ad9027ab48d5b5c5c437b7f46c653 Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Fri, 14 Feb 2020 15:53:00 -0500 Subject: [PATCH 2/2] Propagate vslatestinstalled feature to libsimpleservo. --- ports/libsimpleservo/api/Cargo.toml | 3 ++- ports/libsimpleservo/capi/Cargo.toml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ports/libsimpleservo/api/Cargo.toml b/ports/libsimpleservo/api/Cargo.toml index 0dd05e38561b..dc4241bf92cb 100644 --- a/ports/libsimpleservo/api/Cargo.toml +++ b/ports/libsimpleservo/api/Cargo.toml @@ -50,6 +50,7 @@ no-wgl = ["libservo/no-wgl"] oculusvr = ["libservo/oculusvr"] profilemozjs = ["libservo/profilemozjs"] refcell_backtrace = ["libservo/refcell_backtrace"] -webdriver = ["libservo/webdriver"] uwp = ["libservo/uwp", "webxr/openxr-api"] +vslatestinstalled = ["libservo/vslatestinstalled"] +webdriver = ["libservo/webdriver"] webgl_backtrace = ["libservo/webgl_backtrace"] diff --git a/ports/libsimpleservo/capi/Cargo.toml b/ports/libsimpleservo/capi/Cargo.toml index 2c629587c8f3..f019848ee0be 100644 --- a/ports/libsimpleservo/capi/Cargo.toml +++ b/ports/libsimpleservo/capi/Cargo.toml @@ -46,5 +46,6 @@ oculusvr = ["simpleservo/oculusvr"] profilemozjs = ["simpleservo/profilemozjs"] refcell_backtrace = ["simpleservo/refcell_backtrace"] uwp = ["simpleservo/uwp"] +vslatestinstalled = ["simpleservo/vslatestinstalled"] webdriver = ["simpleservo/webdriver"] webgl_backtrace = ["simpleservo/webgl_backtrace"]