diff --git a/python/servo/package_commands.py b/python/servo/package_commands.py index a663763a3985..f2fd607f784f 100644 --- a/python/servo/package_commands.py +++ b/python/servo/package_commands.py @@ -209,8 +209,11 @@ class PackageCommands(CommandBase): default=None, action='append', help='Create an APPX package') + @CommandArgument('--ms-app-store', + default=None, + action='store_true') def package(self, release=False, dev=False, android=None, magicleap=None, debug=False, - debugger=None, target=None, flavor=None, maven=False, uwp=None): + debugger=None, target=None, flavor=None, maven=False, uwp=None, ms_app_store=False): if android is None: android = self.config["build"]["android"] if target and android: @@ -234,7 +237,7 @@ def package(self, release=False, dev=False, android=None, magicleap=None, debug= target_dir = path.dirname(binary_path) if uwp: vs_info = self.vs_dirs() - build_uwp(uwp, dev, vs_info['msbuild']) + build_uwp(uwp, dev, vs_info['msbuild'], not ms_app_store) elif magicleap: if platform.system() not in ["Darwin"]: raise Exception("Magic Leap builds are only supported on macOS.") @@ -739,7 +742,7 @@ def call_git(cmd, **kwargs): return 0 -def build_uwp(platforms, dev, msbuild_dir): +def build_uwp(platforms, dev, msbuild_dir, sign_package): if any(map(lambda p: p not in ['x64', 'x86', 'arm64'], platforms)): raise Exception("Unsupported appx platforms: " + str(platforms)) if dev and len(platforms) > 1: @@ -764,7 +767,7 @@ def build_uwp(platforms, dev, msbuild_dir): ) build_file.close() # Generate an appxbundle. - subprocess.check_call([msbuild, "/m", build_file.name]) + subprocess.check_call([msbuild, "/m", build_file.name, "/p:AppxPackageSigningEnabled=" + str(sign_package)]) os.unlink(build_file.name) print("Creating ZIP") diff --git a/support/hololens/ServoApp/Package.appxmanifest b/support/hololens/ServoApp/Package.appxmanifest index 53255364338f..0c579a8631b1 100644 --- a/support/hololens/ServoApp/Package.appxmanifest +++ b/support/hololens/ServoApp/Package.appxmanifest @@ -1,6 +1,6 @@  - + Firefox Reality @@ -47,4 +47,4 @@ - + \ No newline at end of file diff --git a/support/hololens/ServoApp/ServoApp.vcxproj b/support/hololens/ServoApp/ServoApp.vcxproj index 917ec1176643..696de8577626 100644 --- a/support/hololens/ServoApp/ServoApp.vcxproj +++ b/support/hololens/ServoApp/ServoApp.vcxproj @@ -63,13 +63,14 @@ False + ServoApp_TemporaryKey.pfx False Always x64 1 OnApplicationRun False - 45A22CA001C9C6BE412BF449FBE70FEDE635831F + DC99ACEDA24EBA00BFB07A3986BB6892B0DE278B diff --git a/support/hololens/ServoApp/ServoApp_TemporaryKey.pfx b/support/hololens/ServoApp/ServoApp_TemporaryKey.pfx index 8917164b3bb5..6aadf2b65b98 100644 Binary files a/support/hololens/ServoApp/ServoApp_TemporaryKey.pfx and b/support/hololens/ServoApp/ServoApp_TemporaryKey.pfx differ diff --git a/support/hololens/package.msbuild b/support/hololens/package.msbuild index d673876c3500..8d25a8d3fd65 100644 --- a/support/hololens/package.msbuild +++ b/support/hololens/package.msbuild @@ -9,6 +9,6 @@ + Properties="Configuration=%(ConfigAndPlatform.Identity);Platform=%(ConfigAndPlatform.Platform);AppxBundle=Always;AppxBundlePlatforms=%%PACKAGE_PLATFORMS%%;UseSubFolderForOutputDirDuringMultiPlatformBuild=false"/> - \ No newline at end of file +