From 0505f451a1f36730a2b1cc9ed6310c0ff0dba4e9 Mon Sep 17 00:00:00 2001 From: JimmyS83 Date: Thu, 7 Feb 2019 14:47:23 +0100 Subject: [PATCH] Add date to the log records --- xbmc/platform/posix/utils/PosixInterfaceForCLog.cpp | 7 +++++-- xbmc/platform/posix/utils/PosixInterfaceForCLog.h | 2 +- xbmc/platform/win32/utils/Win32InterfaceForCLog.cpp | 5 ++++- xbmc/platform/win32/utils/Win32InterfaceForCLog.h | 2 +- xbmc/utils/log.cpp | 9 ++++++--- 5 files changed, 17 insertions(+), 8 deletions(-) diff --git a/xbmc/platform/posix/utils/PosixInterfaceForCLog.cpp b/xbmc/platform/posix/utils/PosixInterfaceForCLog.cpp index 8510dadd79a4f..ce4c5aa5b53da 100644 --- a/xbmc/platform/posix/utils/PosixInterfaceForCLog.cpp +++ b/xbmc/platform/posix/utils/PosixInterfaceForCLog.cpp @@ -83,13 +83,16 @@ void CPosixInterfaceForCLog::PrintDebugString(const std::string &debugString) #endif // _DEBUG } -void CPosixInterfaceForCLog::GetCurrentLocalTime(int &hour, int &minute, int &second, double &milliseconds) +void CPosixInterfaceForCLog::GetCurrentLocalTime(int& year, int& month, int& day, int &hour, int& minute, int& second, double& milliseconds) { struct tm localTime; struct timeval tv; if (gettimeofday(&tv, nullptr) != -1 && localtime_r(&tv.tv_sec, &localTime) != NULL) { + year = localTime.tm_year + 1900; + month = localTime.tm_mon + 1; + day = localTime.tm_mday; hour = localTime.tm_hour; minute = localTime.tm_min; second = localTime.tm_sec; @@ -97,7 +100,7 @@ void CPosixInterfaceForCLog::GetCurrentLocalTime(int &hour, int &minute, int &se } else { - hour = minute = second = 0; + year = month = day = hour = minute = second = 0; milliseconds = 0.0; } } diff --git a/xbmc/platform/posix/utils/PosixInterfaceForCLog.h b/xbmc/platform/posix/utils/PosixInterfaceForCLog.h index 128b59b002037..4e0f6c66467b4 100644 --- a/xbmc/platform/posix/utils/PosixInterfaceForCLog.h +++ b/xbmc/platform/posix/utils/PosixInterfaceForCLog.h @@ -21,7 +21,7 @@ class CPosixInterfaceForCLog void CloseLogFile(void); bool WriteStringToLog(const std::string& logString); void PrintDebugString(const std::string& debugString); - static void GetCurrentLocalTime(int& hour, int& minute, int& second, double& millisecond); + static void GetCurrentLocalTime(int& year, int& month, int& day, int& hour, int& minute, int& second, double& millisecond); private: FILEWRAP* m_file; }; diff --git a/xbmc/platform/win32/utils/Win32InterfaceForCLog.cpp b/xbmc/platform/win32/utils/Win32InterfaceForCLog.cpp index 9c0bb791994b5..3f49c324026ce 100644 --- a/xbmc/platform/win32/utils/Win32InterfaceForCLog.cpp +++ b/xbmc/platform/win32/utils/Win32InterfaceForCLog.cpp @@ -105,10 +105,13 @@ void CWin32InterfaceForCLog::PrintDebugString(const std::string& debugString) #endif // _DEBUG } -void CWin32InterfaceForCLog::GetCurrentLocalTime(int& hour, int& minute, int& second, double& millisecond) +void CWin32InterfaceForCLog::GetCurrentLocalTime(int& year, int& month, int& day, int& hour, int& minute, int& second, double& millisecond) { SYSTEMTIME time; GetLocalTime(&time); + year = time.wYear; + month = time.wMonth; + day = time.wDay; hour = time.wHour; minute = time.wMinute; second = time.wSecond; diff --git a/xbmc/platform/win32/utils/Win32InterfaceForCLog.h b/xbmc/platform/win32/utils/Win32InterfaceForCLog.h index b8ec4edf5ef48..6baf61a3164ea 100644 --- a/xbmc/platform/win32/utils/Win32InterfaceForCLog.h +++ b/xbmc/platform/win32/utils/Win32InterfaceForCLog.h @@ -21,7 +21,7 @@ class CWin32InterfaceForCLog void CloseLogFile(void); bool WriteStringToLog(const std::string& logString); void PrintDebugString(const std::string& debugString); - static void GetCurrentLocalTime(int& hour, int& minute, int& second, double& millisecond); + static void GetCurrentLocalTime(int& year, int& month, int& day, int& hour, int& minute, int& second, double& millisecond); private: HANDLE m_hFile; }; diff --git a/xbmc/utils/log.cpp b/xbmc/utils/log.cpp index 72b326a5e3756..d163727bdd17a 100644 --- a/xbmc/utils/log.cpp +++ b/xbmc/utils/log.cpp @@ -188,17 +188,20 @@ void CLog::PrintDebugString(const std::string& line) bool CLog::WriteLogString(int logLevel, const std::string& logString) { - static const char* prefixFormat = "%02d:%02d:%02d.%03d T:%" PRIu64" %7s: "; + static const char* prefixFormat = "%02d-%02d-%02d %02d:%02d:%02d.%03d T:%" PRIu64" %7s: "; std::string strData(logString); /* fixup newline alignment, number of spaces should equal prefix length */ StringUtils::Replace(strData, "\n", "\n "); - int hour, minute, second; + int year, month, day, hour, minute, second; double millisecond; - g_logState.m_platform.GetCurrentLocalTime(hour, minute, second, millisecond); + g_logState.m_platform.GetCurrentLocalTime(year, month, day, hour, minute, second, millisecond); strData = StringUtils::Format(prefixFormat, + year, + month, + day, hour, minute, second,