From 598cf292df430fda6a4e81f0e449c424ab8bbf74 Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 22 Feb 2022 14:35:50 +0000 Subject: [PATCH 1/2] spec: Fix some typos in the branding section Signed-off-by: Philip Withnall --- docs/xml/metainfo-component.xml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/xml/metainfo-component.xml b/docs/xml/metainfo-component.xml index e84fe6a0..2773b6fd 100644 --- a/docs/xml/metainfo-component.xml +++ b/docs/xml/metainfo-component.xml @@ -1508,11 +1508,12 @@ The <branding/> tag is an optional tag which defines properties affecting the branding and presentation of the - component. It usually affects how it is displayed in software centers and on websites. + component. It usually affects how the component is displayed in software centers and on websites. - The tag may currently only contain color tags as children, defining accent colors for the component as HTML - hexadecimal color string as value. And accent color may for example be used as background behind the logo/icon of an application. + The tag may currently only contain color tags as children, defining accent colors for the component. Each + color element contains an HTML hexadecimal color string as its value. + An accent color may for example be used as the background behind the logo/icon of an application. A color tag must have a type attribute which denotes the color type. It may either From 41f013703dc14110c956067499a0c46e98b1fd1c Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 22 Feb 2022 14:36:11 +0000 Subject: [PATCH 2/2] spec: Require that branding colours start with a hash symbol This will make it easier to extend the colour format to allow non-hexadecimal colours in future (if wanted), without running into problems with ambiguous values. Signed-off-by: Philip Withnall --- docs/xml/metainfo-component.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/xml/metainfo-component.xml b/docs/xml/metainfo-component.xml index 2773b6fd..e9b96464 100644 --- a/docs/xml/metainfo-component.xml +++ b/docs/xml/metainfo-component.xml @@ -1512,7 +1512,7 @@ The tag may currently only contain color tags as children, defining accent colors for the component. Each - color element contains an HTML hexadecimal color string as its value. + color element contains an HTML hexadecimal color string as its value. This string must start with a # character. An accent color may for example be used as the background behind the logo/icon of an application.