Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zero_division parameter consistent in the different metric #29048

Open
5 tasks
glemaitre opened this issue May 19, 2024 · 2 comments
Open
5 tasks

Make zero_division parameter consistent in the different metric #29048

glemaitre opened this issue May 19, 2024 · 2 comments
Milestone

Comments

@glemaitre
Copy link
Member

glemaitre commented May 19, 2024

This is an issue to report the step to actually take over the work of @marctorsoc in #23183 and split the PR into smaller one to facilitate the review process.

The intend is to make the zero_division parameter consistent across different metrics in scikit-learn. In this regards, we have the following TODO list:

  • Introduce the zero_division parameter to the accuracy_score function when y_true and y_pred are empty.
  • Introduce the zero_division parameter to the class_likelihood_ratios and remove raise_warning.
  • Introduce the zero_division parameter to the cohen_kappa_score function.
  • Introduce the zero_division parameter to the matthew_corr_coeff function ENH add zero_division=nan for classification metrics #23183.
  • Open a PR to make sure the empty input lead to np.nan in classification_report function.

All those items have been addressed in #23183 and can be extracted in individual PRs. The changelog presenting the changes should acknowledge @marctorsoc.

In addition, we should investigate #27047 and check if we should add the zero_division parameter to the precision_recall_curve and roc_curve as well. This might add two additional items to the list above.

@glemaitre glemaitre added this to the 1.6 milestone May 19, 2024
@github-actions github-actions bot added the Needs Triage Issue requires triage label May 19, 2024
@glemaitre glemaitre added Enhancement and removed Needs Triage Issue requires triage labels May 19, 2024
@glemaitre
Copy link
Member Author

@StefanieSenger you might be interested in looking at some of the item.

@erikhuck
Copy link

+1 for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants