-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reimplement community header #20049
Comments
@BalogunofAfrica @J-Son89 @cammellos do you remember the final call about blur on Android? I thought we would completely remove it for Android and that we got the green light from designers. Or am I wrong and we will continue to try to implement blur on Android and only remove it in places where we failed to accomplish Figma specs? If that's the case, it still sounds to me like an unnecessary cost in development given its low importance to Android users and how historically blur hasn't been Android's best friend in this repo. |
No idea but for important design decisions like this we need it in a place where we can all point to and communicate out. Otherwise this debate will just keep resurfacing and wasting our resources |
Fully agree. I'll try to check this with designers and get the final word written somewhere. I'm tired too of coming back to this with no final decision. |
This is definitely not the case, we don't have really realistically time for it, so that reason alone can shortcut the decison |
@ilmotta I should have added the notes on Android in the description, done that now. This issue was created because asides the blur issue this PR #19665 tried to fix, @ulisesmac and I agreed that the header for community might need to be reworked. So this is just to keep track till we have free time for it. |
Sorry for hijacking the issue with this blur discussion, but it felt right to try and stamp a final decision about blur on Android that was still floating around (as you could see in Discord). Thanks for updating the requirements @BalogunofAfrica |
fyi #20066 |
Reimplement header component for community, with better scroll handling.
Figma link:
Things to note:
The text was updated successfully, but these errors were encountered: