Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robots 0.1.0 (new formula) #172094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peaceiris
Copy link
Sponsor Contributor

@peaceiris peaceiris commented May 19, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label May 19, 2024
@peaceiris peaceiris force-pushed the google-robotstxt branch 2 times, most recently from f33950d to 2a04ae0 Compare May 19, 2024 08:36
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have one suggestion below.

Also: this seems to download its own googletest and abseil at build-time (from master/main). We should use Homebrew googletest and abseil instead. See:

https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae
https://docs.brew.sh/Acceptable-Formulae#we-dont-like-install-scripts-that-download-unversioned-things

Formula/r/robots.rb Outdated Show resolved Hide resolved
@peaceiris
Copy link
Sponsor Contributor Author

@carlocab
Copy link
Member

https://docs.brew.sh/Acceptable-Formulae#we-dont-like-install-scripts-that-download-unversioned-things

I have opened the following issue to request to create a git tag.

Thanks. There is also the issue of this downloading an unversioned googletest and an unversioned abseil at build-time. We should be able to use Homebrew dependencies instead.

Would you be able to submit a PR upstream that implements this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants