-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable group condition #5248
base: main
Are you sure you want to change the base?
Conversation
As part of AppFlowy-IO#2734 this enables group configuration so grouping by a field can also have more options such as group condition. For example when grouping by a date field type the user can choose to group by day, month, week, etc. Currently group condition is available only for date field type.
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
lint rule | new reports | level | link |
---|---|---|---|
Message without source | 1 | warning | contribute (via Fink 🐦) |
Missing translation | 312 | warning | contribute (via Fink 🐦) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I let some comments on some stuff, but this looks good to me. Great job as always
frontend/appflowy_flutter/lib/plugins/database/widgets/group/database_group.dart
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart
Outdated
Show resolved
Hide resolved
* main: (30 commits) feat: workspace settings page (AppFlowy-IO#5225) fix: kanban board card text input inconsistency (AppFlowy-IO#5307) feat: support scale up/down the app (AppFlowy-IO#5300) fix: android navigation bar issues (AppFlowy-IO#5294) feat: add kanban shortcuts (AppFlowy-IO#5270) chore: use patch to fix version issue (AppFlowy-IO#5291) refactor: mobile view page (AppFlowy-IO#5288) fix: database row page breadcrumbs on smaller screens (AppFlowy-IO#5289) chore: translate english to traditional chinese (AppFlowy-IO#5278) chore: update translations with Fink 🐦 (AppFlowy-IO#5249) feat: support system default font family on desktop (AppFlowy-IO#5279) fix: ws connect with invalid token (AppFlowy-IO#5282) chore: disable ai summary (AppFlowy-IO#5277) fix: color selection compatible with older versions (AppFlowy-IO#5276) chore: bump client api (AppFlowy-IO#5275) fix: assert on uploading image on macos (AppFlowy-IO#5272) fix: launch review improvements (AppFlowy-IO#5263) chore: drop old user awarenss when open workspace (AppFlowy-IO#5271) fix: korean IME issue on Windows (AppFlowy-IO#5267) fix: the cursor will jump up when creating a new document on desktop. (AppFlowy-IO#5269) ...
I'm not sure if the failing test is relevant or not. |
frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/database/board/application/board_bloc.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/plugins/database/widgets/group/database_group.dart
Outdated
Show resolved
Hide resolved
@Xazin fixed all, Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5248 +/- ##
==========================================
+ Coverage 9.70% 86.74% +77.04%
==========================================
Files 685 217 -468
Lines 31812 5032 -26780
Branches 0 831 +831
==========================================
+ Hits 3086 4365 +1279
+ Misses 28726 561 -28165
- Partials 0 106 +106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
As part of #2734 this enables group configuration so grouping by a field can also have more options such as group condition. For example when grouping by a date field type the user can choose to group by day, month, week, etc.
Currently, group condition is available only for date field type.
This is based on what I was trying to do in #3949.
PR Checklist