-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filtering product announcements using contentful #24565
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…aMask/metamask-extension into feat/product-announcements-filtering
The base branch was changed.
…aMask/metamask-extension into feat/product-announcements-filtering
Builds ready [7768ab7]
Page Load Metrics (668 ± 501 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@@ -14,7 +14,7 @@ import { TypeActionFields } from '../types/feature-announcement/type-action'; | |||
|
|||
const spaceId = process.env.CONTENTFUL_ACCESS_SPACE_ID || ''; | |||
const accessToken = process.env.CONTENTFUL_ACCESS_TOKEN || ''; | |||
export const FEATURE_ANNOUNCEMENT_URL = `https://cdn.contentful.com/spaces/${spaceId}/environments/master/entries?access_token=${accessToken}&content_type=productAnnouncement&include=10`; | |||
export const FEATURE_ANNOUNCEMENT_URL = `https://cdn.contentful.com/spaces/${spaceId}/environments/master/entries?access_token=${accessToken}&content_type=productAnnouncement&include=10&fields.clients=extension`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE - this will change in the future with a dedicated API.
This will be done during our work to migrate the controllers into core.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24565 +/- ##
========================================
Coverage 66.00% 66.00%
========================================
Files 1348 1348
Lines 52503 52503
Branches 13494 13494
========================================
Hits 34651 34651
Misses 17852 17852 ☔ View full report in Codecov by Sentry. |
Builds ready [807caa5]
Page Load Metrics (915 ± 554 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This PR introduces a filter for receiving product announcements related to the Extension.
Pre-merge author checklist
Pre-merge reviewer checklist