Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace deprecated chip component with tag in confirm add custo… #24593

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nickpismenkov
Copy link

@nickpismenkov nickpismenkov commented May 18, 2024

…dian token

Description

Replaced deprecated chip component with tag in confirm-add-custodian-token component

Open in GitHub Codespaces

Related issues

Fixes: #20487

Manual testing steps

  1. run "yarn storybook"
  2. open ConfirmAddCustodianToken component

Screenshots/Recordings

Before

Screenshot 2024-05-17 at 20 39 55

After

Screenshot 2024-05-17 at 20 40 37

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@nickpismenkov nickpismenkov requested a review from a team as a code owner May 18, 2024 03:41
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented May 21, 2024

Hey @nickpismenkov, could you please make sure the PR description is complete and includes the manual testing steps for the reviewers? Thanks!

@nickpismenkov
Copy link
Author

@georgewrmarshall Hi. I've completed the description. Could you please help with failed e2e tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Chip component with Tag from the component-library
3 participants