Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reconnect action. #1519

Closed
wants to merge 3 commits into from

Conversation

iFurySt
Copy link
Collaborator

@iFurySt iFurySt commented May 2, 2024

  1. when refreshing the page or socket reconnect: try to reconnect to the already initialized agent. if it doesn't exist, auto init.
  2. reset button: init agent includes related envs like docker containers.
  3. change settings: init agent, same as step 2.
Screen.Recording.2024-05-02.at.21.42.20.mov

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@7d2d2ab). Click here to learn what that means.

Files Patch % Lines
opendevin/server/agent/agent.py 0.00% 5 Missing ⚠️
agenthub/SWE_agent/parser.py 66.66% 1 Missing ⚠️
opendevin/events/observation/__init__.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1519   +/-   ##
=======================================
  Coverage        ?   60.76%           
=======================================
  Files           ?       87           
  Lines           ?     3693           
  Branches        ?        0           
=======================================
  Hits            ?     2244           
  Misses          ?     1449           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

frontend/src/components/AgentControlBar.tsx Outdated Show resolved Hide resolved
frontend/src/components/AgentControlBar.tsx Outdated Show resolved Hide resolved
Signed-off-by: ifuryst <ifuryst@gmail.com>
…action

Signed-off-by: ifuryst <ifuryst@gmail.com>

# Conflicts:
#	opendevin/server/session/msg_stack.py
@iFurySt iFurySt force-pushed the feat-add-reconnect-action branch from 2722ac6 to 47a7793 Compare May 3, 2024 11:37
Signed-off-by: ifuryst <ifuryst@gmail.com>
@iFurySt iFurySt force-pushed the feat-add-reconnect-action branch from 47a7793 to 81e5335 Compare May 3, 2024 11:41
Copy link

@basedanarki basedanarki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 strongly typed docstring

@rbren
Copy link
Collaborator

rbren commented May 9, 2024

@iFurySt lgtm! Just need to fix the conflicts

@iFurySt
Copy link
Collaborator Author

iFurySt commented May 9, 2024

@rbren okay, i'll handle it tomorrow.

@iFurySt iFurySt marked this pull request as draft May 13, 2024 06:07
@neubig
Copy link
Contributor

neubig commented May 31, 2024

Hi @iFurySt , I'm just looking through the backlog and was just wondering what you'd like to do with this PR? Fix the conflicts? Close and possibly do in a different PR? Any way is fine, just checking!

@iFurySt
Copy link
Collaborator Author

iFurySt commented Jun 1, 2024

Hi @iFurySt , I'm just looking through the backlog and was just wondering what you'd like to do with this PR? Fix the conflicts? Close and possibly do in a different PR? Any way is fine, just checking!

I'll close this PR, it's been behind too long.

@iFurySt iFurySt closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants