fix(controller): Improve error info logging #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yufansong
approved these changes
May 18, 2024
li-boxuan
reviewed
May 18, 2024
| @@ -228,6 +230,7 @@ async def _step(self): | |||
|
|
|||
| if self._is_stuck(): | |||
| await self.report_error('Agent got stuck in a loop') | |||
| self.state.error = 'Agent got stuck in a loop' | |||
There was a problem hiding this comment.
This could be part of report_error function?
There was a problem hiding this comment.
I went ahead and pushed a change.
enyst
reviewed
May 19, 2024
enyst
approved these changes
May 20, 2024
li-boxuan
added a commit
to li-boxuan/OpenDevin
that referenced
this pull request
May 21, 2024
* improve error info logging * Move assignment of self.state.error to report_error function * only log exception to state, but not to user --------- Co-authored-by: Boxuan Li <liboxuan@connect.hku.hk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make sure that error will get logged to
state.error.