Fix: Update WebSocket URL to use correct protocol from window.location #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isavita
reviewed
May 19, 2024
SmartManoj
changed the title
isavita
approved these changes
May 19, 2024
|
@SmartManoj @isavita @amanape do you have any ideas to solve this question? i think the two questions are related |
|
@iFurySt, This is the hardcoded value mentioned in that PR. It will solve those browser errors. |
|
Yes I believe this update should resolve both issues. A lot of annoying things happen when trying to create insecure connections with ws to https. |
amanape
approved these changes
May 20, 2024
li-boxuan
pushed a commit
to li-boxuan/OpenDevin
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1649 (comment)