-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add inline code style #1909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I do feel the inline code
is more distinguishable than before, but maybe it could be even better, by making the message background color a bit darker?
@openartist has designed the chat bubble style before, you can use it as a reference. will it look better if add a radius to the code block? wdyt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better! As @iFurySt suggested, the regular code block would also look better if it had some radius on it as well. This PR is a good opportunity to make that change as well.
I think it is either a change to the frontend/src/components/markdown/code.tsx
component or its parent.
@Shimada666 Nice! This looks good |
* feat: add inline code style * feat: add code block radius --------- Co-authored-by: sp.wack <83104063+amanape@users.noreply.github.com>
#1907
use github style