Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document .NET 9 new feature - HybridCache #32605

Merged
merged 8 commits into from
May 20, 2024

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented May 20, 2024

@tdykstra tdykstra marked this pull request as ready for review May 20, 2024 03:42
@tdykstra tdykstra requested a review from wadepickett May 20, 2024 21:41
@wadepickett
Copy link
Contributor

..Reviewing but looks like there was a change while I was looking it over, will wait for the build...

@Rick-Anderson Rick-Anderson merged commit d637cd5 into dotnet:main May 20, 2024
3 checks passed
* Marking the type as `sealed`. The `sealed` keyword in C# means that the class cannot be inherited.
* Applying the `[ImmutableObject(true)]` attribute to the type. The `[ImmutableObject(true)]` attribute indicates that the object's state cannot be changed after it's created.

By reusing instances, `HybridCache` can reduce the overhead of CPU and object allocations associated with per-call deserialization. This can lead to performance improvements in scenarios where the cached objects are large or accessed frequently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestion, not required: Consider moving this paragraph to the intro for this section. I thought it would be helpful to understand this for some context before we jump into the details.


### Compatibility

The library supports older .NET runtimes, down to .NET Framework 4.7.2 and .NET Standard 2.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The library supports older .NET runtimes, down to .NET Framework 4.7.2 and .NET Standard 2.0.
The HybridCache library supports older .NET runtimes, down to .NET Framework 4.7.2 and .NET Standard 2.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to make this more AI friendly. Not required.

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. All I could find were two very minor nits. It merged anyway before I could complete. Understandable this is going quick.

@tdykstra tdykstra deleted the hybridcache branch May 20, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hybrid cache in new doc
4 participants